Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: Source/core/accessibility/AXObjectCacheImpl.h

Issue 670093002: Get rid of AXComputedObjectAttributeCache (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/accessibility/AXObject.cpp ('k') | Source/core/accessibility/AXObjectCacheImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXObjectCacheImpl.h
diff --git a/Source/core/accessibility/AXObjectCacheImpl.h b/Source/core/accessibility/AXObjectCacheImpl.h
index ee35c3e7718752a45fe1d67cd1f085f59fbc2fa5..3906810363b0e37c8e5acd6fb70c217da758f202 100644
--- a/Source/core/accessibility/AXObjectCacheImpl.h
+++ b/Source/core/accessibility/AXObjectCacheImpl.h
@@ -52,27 +52,6 @@ struct TextMarkerData {
EAffinity affinity;
};
-class AXComputedObjectAttributeCache {
-public:
- static PassOwnPtr<AXComputedObjectAttributeCache> create() { return adoptPtr(new AXComputedObjectAttributeCache()); }
-
- AXObjectInclusion getIgnored(AXID) const;
- void setIgnored(AXID, AXObjectInclusion);
-
- void clear();
-
-private:
- AXComputedObjectAttributeCache() { }
-
- struct CachedAXObjectAttributes {
- CachedAXObjectAttributes() : ignored(DefaultBehavior) { }
-
- AXObjectInclusion ignored;
- };
-
- HashMap<AXID, CachedAXObjectAttributes> m_idMapping;
-};
-
enum PostType { PostSynchronously, PostAsynchronously };
// This class should only be used from inside the accessibility directory.
@@ -174,7 +153,9 @@ public:
bool nodeHasRole(Node*, const AtomicString& role);
- AXComputedObjectAttributeCache* computedObjectAttributeCache() { return m_computedObjectAttributeCache.get(); }
+ // Counts the number of times the document has been modified. Some attribute values are cached
+ // as long as the modification count hasn't changed.
+ int modificationCount() const { return m_modificationCount; }
void postNotification(RenderObject*, AXNotification, bool postToElement, PostType = PostAsynchronously);
void postNotification(Node*, AXNotification, bool postToElement, PostType = PostAsynchronously);
@@ -198,7 +179,7 @@ private:
HashMap<Node*, AXID> m_nodeObjectMapping;
HashMap<AbstractInlineTextBox*, AXID> m_inlineTextBoxObjectMapping;
HashSet<Node*> m_textMarkerNodes;
- OwnPtr<AXComputedObjectAttributeCache> m_computedObjectAttributeCache;
+ int m_modificationCount;
HashSet<AXID> m_idsInUse;
« no previous file with comments | « Source/core/accessibility/AXObject.cpp ('k') | Source/core/accessibility/AXObjectCacheImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698