Get rid of AXComputedObjectAttributeCache

Source/core/accessibility/AXObject.h

Index: Source/core/accessibility/AXObject.h
diff --git a/Source/core/accessibility/AXObject.h b/Source/core/accessibility/AXObject.h
index 92bffd57d4b97aeb76025cee25a1b2e5ac2cc718..beee9110c5fe03531f46c92f0d89edc9aea00da3 100644
--- a/Source/core/accessibility/AXObject.h
+++ b/Source/core/accessibility/AXObject.h
@@ -579,6 +579,13 @@ protected:
     unsigned getLengthForTextRange() const { return text().length(); }
 
     bool m_detached;
+
+private:
+    // The following cached attribute values are only valid if m_lastModificationCount matches AXObjectCacheImpl::modificationCount().

[aboxhall, 2014/10/23 21:48:11]

What does "the following cached attribute values" here refer to?

Oh right, just m_cachedIsIgnored. Perhaps this could be reworded slightly more
clearly, something like
"The cached attribute values starting with m_cached* are only valid if
m_lastModificationCount matches ..."

[dmazzoni, 2014/10/23 21:51:52]

Sure. In the following changes I'm hoping to add several more.

+    mutable int m_lastModificationCount;
+    mutable bool m_cachedIsIgnored;
+
+    void updateCachedAttributeValuesIfNeeded() const;
 };
 
 #define DEFINE_AX_OBJECT_TYPE_CASTS(thisType, predicate) \