Issue 670073003: remove OVERRIDE/FINAL presubmit checks now the macros are gone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 670073003: remove OVERRIDE/FINAL presubmit checks now the macros are gone (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore

Modified:
6 years, 2 months ago

Reviewers:
danakj

CC:
chromium-reviews, cc-bugs_chromium.org, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

remove OVERRIDE/FINAL presubmit checks now the macros are gone BUG=417463 Committed: https://crrev.com/a924ebe97ccde57415f5c7fd94109663d2d1d6a2 Cr-Commit-Position: refs/heads/master@{#300681}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -78 lines)			Patch
	M	base/PRESUBMIT.py	View		2 chunks	+0 lines, -41 lines	0 comments	Download
	M	cc/PRESUBMIT.py	View		2 chunks	+0 lines, -37 lines	0 comments	Download

Total messages: 7 (2 generated)

Mostyn Bramley-Moore

@danakj: here's some cleanup for PRESUBMIT.py in cc/ and base/ now that the OVERRIDE and ...

6 years, 2 months ago (2014-10-22 09:27:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670073003/1

6 years, 2 months ago (2014-10-22 14:24:16 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 15:11:36 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a924ebe97ccde57415f5c7fd94109663d2d1d6a2
Cr-Commit-Position: refs/heads/master@{#300681}