Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 670073002: Revert of Add gclient hook to download prebuilt mojo_shell (Closed)

Created:
6 years, 2 months ago by yurys
Modified:
6 years, 2 months ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add gclient hook to download prebuilt mojo_shell (patchset #7 id:120001 of https://codereview.chromium.org/667853002/) Reason for revert: gclient sync fails to execute download_shell_binary.py Original issue's description: > Add gclient hook to download prebuilt mojo_shell > > This adds a gclient hook that downloads prebuilt mojo_shell binaries > from google storage (linux only for now) and gyp/gn flags to toggle > using these prebuilt binaries instead of ones built from source. This > also adds a helper script that uploads a locally built mojo_shell binary > to the appropriate place in google storage. The versioning scheme is: > > *) mojo/public/VERSION contains an identifier (committish currently) for > the mojo public SDK. The mojo_shell binary must match the interfaces > defined in this version of mojo/public/. > > *) gs://mojo/shell/$VERSION/$PLATFORM.zip contains a prebuilt mojo_shell > binary for a particular version. $PLATFORM for now must be linux-x64, > but we can add more later as needed. > > gclient runhooks downloads the shell binary referred to by > mojo/public/VERSION if it is available for the host platform to > mojo/public/tools/prebuilt/ and updates mojo/public/tools/prebuilt/VERSION > to tag the version downloaded if successful. On subsequent runs the hook > will check this against mojo/public/VERSION and avoid downloading again if > the binary is up to date. > > This also adds variables to the GYP and GN builds that control if building > 'mojo' builds a mojo_shell binary from source or copies the prebuilt binary > into the outdir. They both default to false for now. > > R=abarth@chromium.org > > Committed: https://crrev.com/e098527822f3e25fb5b86c1441f7ce6e4c2cfdc8 > Cr-Commit-Position: refs/heads/master@{#300600} TBR=abarth@chromium.org,jamesr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a1db3b6db55da85ff4278d7704cfdaa32e9ea92f Cr-Commit-Position: refs/heads/master@{#300637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -183 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/BUILD.gn View 2 chunks +1 line, -7 lines 0 comments Download
M mojo/mojo.gyp View 3 chunks +21 lines, -42 lines 0 comments Download
D mojo/public/VERSION View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/mojo.gni View 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/public/tools/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/public/tools/download_shell_binary.py View 1 chunk +0 lines, -53 lines 0 comments Download
M mojo/shell/BUILD.gn View 2 chunks +2 lines, -8 lines 0 comments Download
D mojo/tools/upload_shell_binary.py View 1 chunk +0 lines, -39 lines 0 comments Download
M tools/find_depot_tools.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
yurys
Created Revert of Add gclient hook to download prebuilt mojo_shell
6 years, 2 months ago (2014-10-22 05:23:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670073002/1
6 years, 2 months ago (2014-10-22 05:24:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670073002/1
6 years, 2 months ago (2014-10-22 05:32:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 05:32:57 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 05:33:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1db3b6db55da85ff4278d7704cfdaa32e9ea92f
Cr-Commit-Position: refs/heads/master@{#300637}

Powered by Google App Engine
This is Rietveld 408576698