cc: Remove DCHECK code from production.

cc: Remove DCHECK code from production.

Use else { DCHECK_IMPLIES(a, b); } instead of else if (a) { DCHECK(b); }

R=enne, vmpstr

Committed: https://crrev.com/266ef9205cd59f771495a9721ae4e83addf18439
Cr-Commit-Position: refs/heads/master@{#301206}

[danakj, 2014-10-24 20:35:13]

Patchset #1 (id:1) has been deleted

[vmpstr, 2014-10-24 20:41:12]

lgtm

https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer.cc
File cc/layers/picture_layer.cc (right):

https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer....
cc/layers/picture_layer.cc:45: // TODO(ernstm): This DCHECK is only valid as
long as the pile's tiling_rect
I'm not sure what the todo here is, it seems to be just a comment?

[danakj, 2014-10-24 20:42:42]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-10-24 20:43:07]

danakj@chromium.org changed reviewers:
+ ernstm@chromium.org

[danakj, 2014-10-24 20:43:07]

https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer.cc
File cc/layers/picture_layer.cc (right):

https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer....
cc/layers/picture_layer.cc:45: // TODO(ernstm): This DCHECK is only valid as
long as the pile's tiling_rect
On 2014/10/24 20:41:12, vmpstr wrote:
> I'm not sure what the todo here is, it seems to be just a comment?

Ya.. not sure either.

[danakj, 2014-10-24 20:43:10]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-10-24 20:44:30]

https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer.cc
File cc/layers/picture_layer.cc (right):

https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer....
cc/layers/picture_layer.cc:45: // TODO(ernstm): This DCHECK is only valid as
long as the pile's tiling_rect
On 2014/10/24 20:43:07, danakj wrote:
> On 2014/10/24 20:41:12, vmpstr wrote:
> > I'm not sure what the todo here is, it seems to be just a comment?
> 
> Ya.. not sure either.

I think this is from when we were going to use non-0 origin for tilingdata
maybe. I'm going to remove it.

[danakj, 2014-10-24 20:50:05]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-10-24 20:50:19]

On 2014/10/24 20:44:30, danakj wrote:
>
https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer.cc
> File cc/layers/picture_layer.cc (right):
> 
>
https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer....
> cc/layers/picture_layer.cc:45: // TODO(ernstm): This DCHECK is only valid as
> long as the pile's tiling_rect
> On 2014/10/24 20:43:07, danakj wrote:
> > On 2014/10/24 20:41:12, vmpstr wrote:
> > > I'm not sure what the todo here is, it seems to be just a comment?
> > 
> > Ya.. not sure either.
> 
> I think this is from when we were going to use non-0 origin for tilingdata
> maybe. I'm going to remove it.

Manfred confirmed, removing it (thanks!)

[enne (OOO), 2014-10-24 20:50:24]

lgtm2

https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer.cc
File cc/layers/picture_layer.cc (right):

https://codereview.chromium.org/670063008/diff/20001/cc/layers/picture_layer....
cc/layers/picture_layer.cc:45: // TODO(ernstm): This DCHECK is only valid as
long as the pile's tiling_rect
On 2014/10/24 at 20:44:30, danakj wrote:
> On 2014/10/24 20:43:07, danakj wrote:
> > On 2014/10/24 20:41:12, vmpstr wrote:
> > > I'm not sure what the todo here is, it seems to be just a comment?
> > 
> > Ya.. not sure either.
> 
> I think this is from when we were going to use non-0 origin for tilingdata
maybe. I'm going to remove it.

Yes, that's exactly it.

[enne (OOO), 2014-10-24 20:50:51]

lgtm 3 (I'm so sad lgtm2 no longer counts.)

[commit-bot: I haz the power, 2014-10-24 20:50:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670063008/40001

[commit-bot: I haz the power, 2014-10-24 22:12:56]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2014-10-24 22:13:23]

Patchset 2 (id:??) landed as
https://crrev.com/266ef9205cd59f771495a9721ae4e83addf18439
Cr-Commit-Position: refs/heads/master@{#301206}