Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: test/same-source-file-name/gyptest-shared.py

Issue 670063006: Stop checking for duplicate basenames (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/same-source-file-name/gyptest-shared.py
diff --git a/test/same-source-file-name/gyptest-shared.py b/test/same-source-file-name/gyptest-shared.py
index a57eb6159e492c7f8cc58481027eae82ad2b15c3..3b9465e69127ed6bc71a88e4a91e7ed2efe0aed2 100755
--- a/test/same-source-file-name/gyptest-shared.py
+++ b/test/same-source-file-name/gyptest-shared.py
@@ -15,16 +15,12 @@ import TestGyp
test = TestGyp.TestGyp()
-# Fails by default for the compatibility with Visual C++ 2008 generator.
-# TODO: Update expected behavior when these legacy generators are deprecated.
-test.run_gyp('double-shared.gyp', chdir='src', status=1, stderr=None)
-
if ((test.format == 'msvs') and
(int(os.environ.get('GYP_MSVS_VERSION', 2010)) < 2010)):
- test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check',
+ test.run_gyp('double-shared.gyp',
chdir='src', status=0, stderr=None)
else:
- test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check',
+ test.run_gyp('double-shared.gyp',
chdir='src')
test.build('double-shared.gyp', test.ALL, chdir='src')

Powered by Google App Engine
This is Rietveld 408576698