Stop checking for duplicate basenames

Stop checking for duplicate basenames

Chromium doesn't care about MSVC08 or Mac OS X makefiles anymore,
whereas some third_party libraries we'd like to use within Chromium
contain source files with duplicate basenames.

Discussion link: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/0rDiXgLvywY/sm0LSj-hiDIJ

Patch from mdempsky@chromium.org

R=scottmg@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1993

[mdempsky, 2014-10-23 22:53:53]

mdempsky@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2014-10-23 22:59:44]

lgtm

https://codereview.chromium.org/670063006/diff/1/test/same-source-file-name/g...
File test/same-source-file-name/gyptest-shared.py (left):

https://codereview.chromium.org/670063006/diff/1/test/same-source-file-name/g...
test/same-source-file-name/gyptest-shared.py:8: Checks that gyp fails on
shared_library targets which have several files with
fails->succeeds

https://codereview.chromium.org/670063006/diff/1/test/same-source-file-name/g...
File test/same-source-file-name/gyptest-static.py (left):

https://codereview.chromium.org/670063006/diff/1/test/same-source-file-name/g...
test/same-source-file-name/gyptest-static.py:8: Checks that gyp fails on
static_library targets which have several files with
same

[mdempsky, 2014-10-23 23:08:56]

https://codereview.chromium.org/670063006/diff/1/test/same-source-file-name/g...
File test/same-source-file-name/gyptest-shared.py (left):

https://codereview.chromium.org/670063006/diff/1/test/same-source-file-name/g...
test/same-source-file-name/gyptest-shared.py:8: Checks that gyp fails on
shared_library targets which have several files with
On 2014/10/23 22:59:44, scottmg wrote:
> fails->succeeds

Done.

https://codereview.chromium.org/670063006/diff/1/test/same-source-file-name/g...
File test/same-source-file-name/gyptest-static.py (left):

https://codereview.chromium.org/670063006/diff/1/test/same-source-file-name/g...
test/same-source-file-name/gyptest-static.py:8: Checks that gyp fails on
static_library targets which have several files with
On 2014/10/23 22:59:44, scottmg wrote:
> same

Done.

[scottmg, 2014-10-23 23:13:42]

Could you also please add some rationale to the CL description? Then I can
trybot/land.

[mdempsky, 2014-10-23 23:17:47]

On 2014/10/23 23:13:42, scottmg wrote:
> Could you also please add some rationale to the CL description? Then I can
> trybot/land.

Done, PTAL.

[scottmg, 2014-10-23 23:18:35]

Thanks, I'll let when bots look ok.

[scottmg, 2014-10-23 23:19:36]

On 2014/10/23 23:18:35, scottmg wrote:
> Thanks, I'll let when bots look ok.

Er, s/let/land/

[scottmg, 2014-10-24 00:15:58]

Committed patchset #2 (id:20001) manually as 1993 (presubmit successful).

[Nico, 2015-05-21 19:36:42]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-05-21 19:36:42]

This does not lgtm. If targets have multiple identical basenames, libtools will
print warnings on OS X. We want a warning-free build.

[scottmg, 2015-05-21 19:39:37]

On 2015/05/21 19:36:42, Nico wrote:
> This does not lgtm. If targets have multiple identical basenames, libtools
will
> print warnings on OS X. We want a warning-free build.

Sorry, my fault. I thought based on the description it was make-specific for
Mac, but I should have checked.

I suspect those files haven't changed too much, so it should revert pretty
easily. I guess something must have duplicate basenames now though so we
probably need to be careful how it's rolled out?

[scottmg, 2015-05-21 19:41:51]

(Any chance of complaining to libtool owners, btw?)

[yukawa, 2015-05-21 20:20:05]

On 2015/05/21 19:41:51, scottmg wrote:
> (Any chance of complaining to libtool owners, btw?)

Last time I checked, xcode worked around that limitation by internally renaming
duplicate basenames.  Perhaps we could do the same thing in gyp/Ninja layer?