Issue 670043002: Add PRESUBMIT check for deprecated JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 670043002: Add PRESUBMIT check for deprecated JS. (Closed)

Created:
6 years, 2 months ago by Dan Beam

Modified:
6 years, 2 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Julien - ping for review

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Add PRESUBMIT check for deprecated JS. Start with __lookupGetter__, __defineGetter__, and __defineSetter__. R=maruel@chromium.org BUG=425829 Committed: https://crrev.com/070cfe614915394d0066c30ad7efb649b9a91ef6 Cr-Commit-Position: refs/heads/master@{#300641}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
	M	PRESUBMIT.py	View	1	3 chunks	+27 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670043002/20001

6 years, 2 months ago (2014-10-22 05:47:32 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 06:45:30 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/070cfe614915394d0066c30ad7efb649b9a91ef6
Cr-Commit-Position: refs/heads/master@{#300641}