Issue 670013002: More virtual/override updates in base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 670013002: More virtual/override updates in base/. (Closed)

Created:
6 years, 2 months ago by viettrungluu

Modified:
6 years, 2 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More virtual/override updates in base/. (These aren't built on Mac, only on Linux, hence were missed.) BUG=417463 R=thestig@chromium.org Committed: https://crrev.com/b9f1b8122dd9e1880c4957e068f323fd4138cfc6 Cr-Commit-Position: refs/heads/master@{#300611}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	base/files/file_path_watcher_linux.cc	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	base/message_loop/message_pump_glib.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	base/process/kill_posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670013002/1

6 years, 2 months ago (2014-10-21 22:20:08 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 04:05:10 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b9f1b8122dd9e1880c4957e068f323fd4138cfc6
Cr-Commit-Position: refs/heads/master@{#300611}