Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 669993004: Fix display list canvas fallback to GPU accelerated mode (Closed)

Created:
6 years, 2 months ago by Justin Novosad
Modified:
6 years, 2 months ago
Reviewers:
Stephen White
CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

Fix display list canvas fallback to GPU accelerated mode Right now when the display list canvas fallback is triggered, and the fallback canvas is GPU-acclerated, we fail to notify the GraphicsContext that it has become accelerated. This causes HTMLCanvasElement::paint to use the CPU rendering code path. This change fix the problem by notifying the GraphicsContext of whether GPU acceleration is use by the fallback canvas. BUG=426169 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/platform/graphics/RecordingImageBufferSurface.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Justin Novosad
review ping.
6 years, 2 months ago (2014-10-24 17:31:42 UTC) #2
Stephen White
Tests would be nice, but LGTM since it's small.
6 years, 2 months ago (2014-10-24 17:44:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669993004/1
6 years, 2 months ago (2014-10-24 17:54:54 UTC) #5
Justin Novosad
FYI: We'll have all the testing we need once we flip the switch on the ...
6 years, 2 months ago (2014-10-24 18:08:27 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 19:28:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184379

Powered by Google App Engine
This is Rietveld 408576698