use SkMaskCache inside SkBlurMaskFilter

use SkMaskCache inside SkBlurMaskFilter

depends on https://codereview.chromium.org/670063004/

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4dca7a829635b552be369186ff508a94aba6a903

[reed1, 2014-10-22 15:17:53]

reed@google.com changed reviewers:
+ mtklein@google.com, qiankun.miao@intel.com

[reed1, 2014-10-23 17:00:55]

1. added quality param to rects[] case
2. reorder params for more consistency (keep common together: sigma, style,
quality)
3. remove unneeded count field in rects[] key

ptal

[reed1, 2014-10-23 17:05:03]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-10-23 17:05:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669993003/20001

[commit-bot: I haz the power, 2014-10-23 17:05:52]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-10-23 23:05 UTC

[reed1, 2014-10-23 17:06:19]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-10-23 17:07:54]

reed@google.com changed reviewers:
+ fmalita@google.com

[mtklein, 2014-10-23 18:18:10]

lgtm

https://codereview.chromium.org/669993003/diff/20001/src/effects/SkBlurMaskFi...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/669993003/diff/20001/src/effects/SkBlurMaskFi...
src/effects/SkBlurMaskFilter.cpp:266: SkASSERT(computed_size <= size);
Might just

SkASSERT(mask->computeTotalImageSize() <= size);

[reed1, 2014-10-23 19:22:51]

https://codereview.chromium.org/669993003/diff/20001/src/effects/SkBlurMaskFi...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/669993003/diff/20001/src/effects/SkBlurMaskFi...
src/effects/SkBlurMaskFilter.cpp:266: SkASSERT(computed_size <= size);
On 2014/10/23 18:18:10, mtklein wrote:
> Might just
> 
> SkASSERT(mask->computeTotalImageSize() <= size);

Done.

[reed1, 2014-10-23 19:24:09]

qiankun, I propose landing this, so we can address the perf bug in chrome. We
can always revisit the idea of carrying the cache-data around, as a further
optimization. If we come up with such a change, it should be easy to land on top
of this one.

[reed1, 2014-10-23 19:33:15]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-10-23 19:34:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669993003/40001

[commit-bot: I haz the power, 2014-10-23 19:42:51]

Committed patchset #3 (id:40001) as 4dca7a829635b552be369186ff508a94aba6a903