Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 669983002: Draw SKPs in 256x256 tiles in nanobench. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Draw SKPs in 256x256 tiles in nanobench. (This CL will certainly trigger performance regression alerts. Tiled drawing is slower than non-tiled drawing.) BUG=skia: Committed: https://skia.googlesource.com/skia/+/c7f7f467df07be73b22dbee38a59762997eb19bc

Patch Set 1 #

Patch Set 2 : int -> float #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M bench/SKPBench.cpp View 1 2 chunks +19 lines, -6 lines 0 comments Download
M bench/nanobench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein
6 years, 2 months ago (2014-10-21 18:50:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669983002/1
6 years, 2 months ago (2014-10-21 18:50:59 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-21 18:51:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/150)
6 years, 2 months ago (2014-10-21 18:54:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669983002/20001
6 years, 2 months ago (2014-10-21 18:59:15 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-21 18:59:15 UTC) #10
robertphillips
lgtm
6 years, 2 months ago (2014-10-21 19:27:32 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 19:29:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as c7f7f467df07be73b22dbee38a59762997eb19bc

Powered by Google App Engine
This is Rietveld 408576698