Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 669963003: Fix flaky headers stream test in quic_session_test. (Closed)

Created:
6 years, 2 months ago by rjshade
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix flaky headers stream test in quic_session_test. Randomly sized test headers would occasionally fit exactly in the stream flow control window, resulting in the stream being flow control blocked but without any pending queued data. Do one extra write after becoming blocked to ensure there is queued data. BUG=423586 Committed: https://crrev.com/44441da8c0837f30dbf3773eef35813f7dc61ffc Cr-Commit-Position: refs/heads/master@{#300684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M net/quic/quic_session_test.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ramant (doing other things)
lgtm Thanks rjshade@ for the fix.
6 years, 2 months ago (2014-10-21 21:28:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669963003/1
6 years, 2 months ago (2014-10-21 21:31:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/20512)
6 years, 2 months ago (2014-10-21 22:01:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669963003/1
6 years, 2 months ago (2014-10-22 15:44:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 16:04:40 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 16:05:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44441da8c0837f30dbf3773eef35813f7dc61ffc
Cr-Commit-Position: refs/heads/master@{#300684}

Powered by Google App Engine
This is Rietveld 408576698