Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: ipc/ipc_channel_posix.h

Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_factory.cc ('k') | ipc/ipc_channel_posix_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_posix.h
diff --git a/ipc/ipc_channel_posix.h b/ipc/ipc_channel_posix.h
index 1cb76102c3905eba818929ed536a73f47f048111..717e43ee05fa710b27db64af7530360d2fcfef8c 100644
--- a/ipc/ipc_channel_posix.h
+++ b/ipc/ipc_channel_posix.h
@@ -56,16 +56,16 @@
public:
ChannelPosix(const IPC::ChannelHandle& channel_handle, Mode mode,
Listener* listener);
- ~ChannelPosix() override;
+ virtual ~ChannelPosix();
// Channel implementation
- bool Connect() override;
- void Close() override;
- bool Send(Message* message) override;
- base::ProcessId GetPeerPID() const override;
- base::ProcessId GetSelfPID() const override;
- int GetClientFileDescriptor() const override;
- base::ScopedFD TakeClientFileDescriptor() override;
+ virtual bool Connect() override;
+ virtual void Close() override;
+ virtual bool Send(Message* message) override;
+ virtual base::ProcessId GetPeerPID() const override;
+ virtual base::ProcessId GetSelfPID() const override;
+ virtual int GetClientFileDescriptor() const override;
+ virtual base::ScopedFD TakeClientFileDescriptor() override;
// Returns true if the channel supports listening for connections.
bool AcceptsConnections() const;
@@ -102,10 +102,12 @@
void QueueCloseFDMessage(int fd, int hops);
// ChannelReader implementation.
- ReadState ReadData(char* buffer, int buffer_len, int* bytes_read) override;
- bool WillDispatchInputMessage(Message* msg) override;
- bool DidEmptyInputBuffers() override;
- void HandleInternalMessage(const Message& msg) override;
+ virtual ReadState ReadData(char* buffer,
+ int buffer_len,
+ int* bytes_read) override;
+ virtual bool WillDispatchInputMessage(Message* msg) override;
+ virtual bool DidEmptyInputBuffers() override;
+ virtual void HandleInternalMessage(const Message& msg) override;
#if defined(IPC_USES_READWRITE)
// Reads the next message from the fd_pipe_ and appends them to the
@@ -127,8 +129,8 @@
void ClearInputFDs();
// MessageLoopForIO::Watcher implementation.
- void OnFileCanReadWithoutBlocking(int fd) override;
- void OnFileCanWriteWithoutBlocking(int fd) override;
+ virtual void OnFileCanReadWithoutBlocking(int fd) override;
+ virtual void OnFileCanWriteWithoutBlocking(int fd) override;
Mode mode_;
« no previous file with comments | « ipc/ipc_channel_factory.cc ('k') | ipc/ipc_channel_posix_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698