Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: ipc/ipc_channel_factory.cc

Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_posix.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/ipc_channel_factory.h" 5 #include "ipc/ipc_channel_factory.h"
6 6
7 namespace IPC { 7 namespace IPC {
8 8
9 namespace { 9 namespace {
10 10
11 class PlatformChannelFactory : public ChannelFactory { 11 class PlatformChannelFactory : public ChannelFactory {
12 public: 12 public:
13 PlatformChannelFactory(ChannelHandle handle, 13 PlatformChannelFactory(ChannelHandle handle,
14 Channel::Mode mode) 14 Channel::Mode mode)
15 : handle_(handle), mode_(mode) { 15 : handle_(handle), mode_(mode) {
16 } 16 }
17 17
18 std::string GetName() const override { return handle_.name; } 18 virtual std::string GetName() const override {
19 return handle_.name;
20 }
19 21
20 scoped_ptr<Channel> BuildChannel(Listener* listener) override { 22 virtual scoped_ptr<Channel> BuildChannel(
23 Listener* listener) override {
21 return Channel::Create(handle_, mode_, listener); 24 return Channel::Create(handle_, mode_, listener);
22 } 25 }
23 26
24 private: 27 private:
25 ChannelHandle handle_; 28 ChannelHandle handle_;
26 Channel::Mode mode_; 29 Channel::Mode mode_;
27 30
28 DISALLOW_COPY_AND_ASSIGN(PlatformChannelFactory); 31 DISALLOW_COPY_AND_ASSIGN(PlatformChannelFactory);
29 }; 32 };
30 33
31 } // namespace 34 } // namespace
32 35
33 // static 36 // static
34 scoped_ptr<ChannelFactory> ChannelFactory::Create( 37 scoped_ptr<ChannelFactory> ChannelFactory::Create(
35 const ChannelHandle& handle, Channel::Mode mode) { 38 const ChannelHandle& handle, Channel::Mode mode) {
36 return scoped_ptr<ChannelFactory>(new PlatformChannelFactory(handle, mode)); 39 return scoped_ptr<ChannelFactory>(new PlatformChannelFactory(handle, mode));
37 } 40 }
38 41
39 } // namespace IPC 42 } // namespace IPC
OLDNEW
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_posix.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698