chrome/browser/ui/browser.cc - Issue 66993003: Most references to GetActiveEntry removed from chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 66993003: Most references to GetActiveEntry removed from chrome/browser/ui. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updates from nasko comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 059efd26b506f7cdef195a44c7245636f0498256..fe68d18dacef735618cc45dde6baf08110c07f19 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -1441,7 +1441,7 @@ void Browser::BeforeUnloadFired(WebContents* web_contents,

bool Browser::ShouldFocusLocationBarByDefault(WebContents* source) {

const content::NavigationEntry* entry =

- source->GetController().GetActiveEntry();

+ source->GetController().GetVisibleEntry();

if (entry) {

GURL url = entry->GetURL();

GURL virtual_url = entry->GetVirtualURL();