Most references to GetActiveEntry removed from chrome/browser/ui.

chrome/browser/ui/tabs/pinned_tab_codec.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/tabs/pinned_tab_codec.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/tab_helper.h"
@@ skipping 49 matching lines @@
         extensions::TabHelper::FromWebContents(web_contents)->extension_app();
     DCHECK(extension);
     value->SetString(kAppID, extension->id());
     // For apps we use the launch url. We do this because the user is
     // effectively restarting the app, so returning them to the app's launch
     // page seems closest to what they expect.
     value->SetString(
         kURL, extensions::AppLaunchInfo::GetFullLaunchURL(extension).spec());
     values->Append(value.release());
   } else {
-    NavigationEntry* entry = web_contents->GetController().GetActiveEntry();
+    NavigationEntry* entry = web_contents->GetController().GetVisibleEntry();

[nasko, 2013/11/08 23:52:03]

Why not LastCommitted here?

[jww, 2013/11/11 19:18:51]

In this case, my thinking was that a user is trying to pin the URL that they see
in the omnibox, not the content, but I suppose that's debatable. What do you
think? Probably needs confirmation from an owner either way on this one.

     if (!entry && web_contents->GetController().GetEntryCount())
       entry = web_contents->GetController().GetEntryAtIndex(0);
     if (entry) {
       value->SetString(kURL, entry->GetURL().spec());
       values->Append(value.release());
     }
   }
 }
 
 // Invokes EncodePinnedTab for each pinned tab in browser.
@@ skipping 76 matching lines @@
   for (size_t i = 0, max = tabs_list->GetSize(); i < max; ++i) {
     const base::DictionaryValue* tab_values = NULL;
     if (tabs_list->GetDictionary(i, &tab_values)) {
       StartupTab tab;
       if (DecodeTab(*tab_values, &tab))
         results.push_back(tab);
     }
   }
   return results;
 }