Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 669883003: Prevent inherited style from propagating into a plugin placeholder. (Closed)

Created:
6 years, 1 month ago by jbroman
Modified:
6 years, 1 month ago
Reviewers:
esprehn, Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Mike West
Project:
blink
Visibility:
Public.

Description

Prevent inherited style from propagating into a plugin placeholder. Without setting 'all: initial', it's possible for text colours and such to be inherited by the placeholder, which is unexpected. TEST=fast/plugins/plugin-placeholder-inherit.html BUG=364716 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184878 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185298

Patch Set 1 #

Patch Set 2 : text-transform #

Patch Set 3 : also add to baseline css file for consistency #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M LayoutTests/fast/plugins/plugin-placeholder.css View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/plugins/plugin-placeholder-inherit.html View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + LayoutTests/fast/plugins/plugin-placeholder-inherit-expected.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/PluginPlaceholderElement.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
jbroman
This should be pretty trivial. Ref test uses "color" (most likely thing to be visible ...
6 years, 1 month ago (2014-10-30 15:27:55 UTC) #2
jbroman
+mkwst in case esprehn is too busy to do reviews bump (5 days with no ...
6 years, 1 month ago (2014-11-04 23:17:13 UTC) #4
Mike West
LGTM.
6 years, 1 month ago (2014-11-05 07:40:02 UTC) #5
esprehn
lgtm
6 years, 1 month ago (2014-11-05 16:45:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669883003/40001
6 years, 1 month ago (2014-11-05 17:47:15 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 184878
6 years, 1 month ago (2014-11-05 17:49:14 UTC) #9
dcheng
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/706623003/ by dcheng@chromium.org. ...
6 years, 1 month ago (2014-11-05 19:21:42 UTC) #10
jbroman
On 2014/11/05 19:21:42, dcheng wrote: > A revert of this CL (patchset #3 id:40001) has ...
6 years, 1 month ago (2014-11-11 21:15:05 UTC) #11
jbroman
On 2014/11/11 21:15:05, jbroman wrote: > On 2014/11/05 19:21:42, dcheng wrote: > > A revert ...
6 years, 1 month ago (2014-11-13 14:49:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669883003/60001
6 years, 1 month ago (2014-11-13 14:50:14 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 15:43:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 185298

Powered by Google App Engine
This is Rietveld 408576698