Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 669873003: Avoid sub-tree style recalc for ::selection. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
chrishtr, esprehn, dglazkov
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid sub-tree style recalc for ::selection. The presence of the ::selection pseudo element should not trigger a sub-tree style recalc from style invalidation. The same goes for the :window-inactive pseudo class. R=chrishtr@chromium.org,esprehn@chromium.org BUG=425494 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
A LayoutTests/fast/css/invalidation/selection-pseudo.html View 1 chunk +68 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/selection-pseudo-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rune
6 years, 2 months ago (2014-10-21 10:47:28 UTC) #1
rune
PTAL
6 years, 2 months ago (2014-10-24 08:51:41 UTC) #2
dglazkov
lgtm
6 years, 2 months ago (2014-10-24 15:01:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669873003/1
6 years, 2 months ago (2014-10-24 15:01:58 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:05:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184367

Powered by Google App Engine
This is Rietveld 408576698