Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: chrome/browser/devtools/devtools_file_helper.cc

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_file_helper.cc
diff --git a/chrome/browser/devtools/devtools_file_helper.cc b/chrome/browser/devtools/devtools_file_helper.cc
index fa6df0c7f14070cb590c33138c31b7333ccd6127..78bc9a4ca3ff8e2629b4a983e3b6e5433b4bd2ff 100644
--- a/chrome/browser/devtools/devtools_file_helper.cc
+++ b/chrome/browser/devtools/devtools_file_helper.cc
@@ -87,27 +87,27 @@ class SelectFileDialog : public ui::SelectFileDialog::Listener,
}
// ui::SelectFileDialog::Listener implementation.
- virtual void FileSelected(const base::FilePath& path,
- int index,
- void* params) override {
+ void FileSelected(const base::FilePath& path,
+ int index,
+ void* params) override {
selected_callback_.Run(path);
Release(); // Balanced in ::Show.
}
- virtual void MultiFilesSelected(const std::vector<base::FilePath>& files,
- void* params) override {
+ void MultiFilesSelected(const std::vector<base::FilePath>& files,
+ void* params) override {
Release(); // Balanced in ::Show.
NOTREACHED() << "Should not be able to select multiple files";
}
- virtual void FileSelectionCanceled(void* params) override {
+ void FileSelectionCanceled(void* params) override {
canceled_callback_.Run();
Release(); // Balanced in ::Show.
}
private:
friend class base::RefCounted<SelectFileDialog>;
- virtual ~SelectFileDialog() {}
+ ~SelectFileDialog() override {}
scoped_refptr<ui::SelectFileDialog> select_file_dialog_;
SelectedCallback selected_callback_;

Powered by Google App Engine
This is Rietveld 408576698