net/tools/quic/test_tools/quic_test_utils.cc - Issue 669813003: Update from chromium https://crrev.com/301725/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/test_tools/quic_test_utils.cc

Issue 669813003: Update from chromium https://crrev.com/301725/ (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/test_tools/quic_test_utils.cc

diff --git a/net/tools/quic/test_tools/quic_test_utils.cc b/net/tools/quic/test_tools/quic_test_utils.cc

index 781b3c36bd058bcd9993bb03c9dccdea82ade223..2477483dc4b0a71b8ab5ed471fd332381ef0f7b1 100644

--- a/net/tools/quic/test_tools/quic_test_utils.cc

+++ b/net/tools/quic/test_tools/quic_test_utils.cc

@@ -23,10 +23,9 @@ class NiceMockPacketWriterFactory

: public QuicConnection::PacketWriterFactory {

public:

NiceMockPacketWriterFactory() {}

- virtual ~NiceMockPacketWriterFactory() {}

+ ~NiceMockPacketWriterFactory() override {}

- virtual QuicPacketWriter* Create(

- QuicConnection* /*connection*/) const override {

+ QuicPacketWriter* Create(QuicConnection* /*connection*/) const override {

return new testing::NiceMock<MockPacketWriter>();

}