base/logging.h - Issue 669813003: Update from chromium https://crrev.com/301725/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 669813003: Update from chromium https://crrev.com/301725/ (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index 54ff57970abe2b5a63507ce77e11f5ae698ef457..6a1df765895c23c0e5211497e63a6a5fba8dc54f 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -701,7 +701,7 @@ const LogSeverity LOG_DCHECK = LOG_INFO;

#define DCHECK_GT(val1, val2) DCHECK_OP(GT, > , val1, val2)

#define DCHECK_IMPLIES(val1, val2) DCHECK(!(val1) || (val2))

-#if defined(NDEBUG) && defined(OS_CHROMEOS)

+#if !DCHECK_IS_ON && defined(OS_CHROMEOS)

#define NOTREACHED() LOG(ERROR) << "NOTREACHED() hit in " << \

__FUNCTION__ << ". "

#else

« no previous file with comments | « base/files/file_util_unittest.cc ('k') | base/path_service_unittest.cc » ('j') | no next file with comments »