Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 669813002: Add an assert that we still have a buffer to readFromBuffer(). (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add an assert that we still have a buffer to readFromBuffer(). sk_free(fBuffer.detach()) means fBuffer will be left as NULL, not a zero-length malloc. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1f66e4539177297545270ff3cbd1d8fa6c3481ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/utils/SkFrontBufferedStream.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein
6 years, 2 months ago (2014-10-20 23:17:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669813002/1
6 years, 2 months ago (2014-10-20 23:17:50 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-20 23:17:50 UTC) #7
scroggo
lgtm
6 years, 2 months ago (2014-10-20 23:21:40 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 14:12:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 1f66e4539177297545270ff3cbd1d8fa6c3481ac

Powered by Google App Engine
This is Rietveld 408576698