Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 669803002: Optimize for horizontal writing mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 669803002: Optimize for horizontal writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed RenderView to use hasFlippedBlocksWritingMode Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/Source/core/css/resolver/StyleBuilderCustom.cpp b/Source/core/css/resolver/StyleBuilderCustom.cpp

index 61f9469503e9409c0ba3b885b951b06d94bc637f..d977f1106d4226dbfac3a4755b3ea2280fe47fb8 100644

--- a/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -897,8 +897,12 @@ void StyleBuilderFunctions::applyValueCSSPropertyWebkitAppRegion(StyleResolverSt

void StyleBuilderFunctions::applyValueCSSPropertyWebkitWritingMode(StyleResolverState& state, CSSValue* value)

{

- if (value->isPrimitiveValue())

- state.setWritingMode(*toCSSPrimitiveValue(value));

+ if (value->isPrimitiveValue()) {

+ CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

+ state.setWritingMode(*primitiveValue);

+ if (!isHorizontalWritingMode(*primitiveValue))

+ state.document().setContainsAnyVerticalWritingModes(true);

+ }

// FIXME: It is not ok to modify document state while applying style.

if (state.element() && state.element() == state.document().documentElement())

« no previous file with comments | « no previous file | Source/core/dom/Document.h » ('j') | Source/core/page/EventHandler.cpp » ('J')