Source/core/rendering/RenderText.cpp - Issue 669803002: Optimize for horizontal writing mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderText.cpp

Issue 669803002: Optimize for horizontal writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Moved logic to RenderBlock as suggested by pdr Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderText.cpp

diff --git a/Source/core/rendering/RenderText.cpp b/Source/core/rendering/RenderText.cpp

index d083b2e1d0596e6d4d2ad3d09a16496e6ff82450..234913c40b723c99813530735e8e5326ae84df5c 100644

--- a/Source/core/rendering/RenderText.cpp

+++ b/Source/core/rendering/RenderText.cpp

@@ -603,7 +603,7 @@ PositionWithAffinity RenderText::positionForPoint(const LayoutPoint& point)

LayoutUnit pointLineDirection = firstTextBox()->isHorizontal() ? point.x() : point.y();

LayoutUnit pointBlockDirection = firstTextBox()->isHorizontal() ? point.y() : point.x();

- bool blocksAreFlipped = style()->isFlippedBlocksWritingMode();

+ bool blocksAreFlipped = style()->slowIsFlippedBlocksWritingMode();

InlineTextBox* lastBox = 0;

for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) {