Source/core/rendering/RenderTable.cpp - Issue 669803002: Optimize for horizontal writing mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTable.cpp

Issue 669803002: Optimize for horizontal writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Moved logic to RenderBlock as suggested by pdr Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderTable.cpp

diff --git a/Source/core/rendering/RenderTable.cpp b/Source/core/rendering/RenderTable.cpp

index 66d8feb0464158bcba589955c13e220392d6e5e9..cf2d2f351589b448cf2ef03272db9bd3e88b3167 100644

--- a/Source/core/rendering/RenderTable.cpp

+++ b/Source/core/rendering/RenderTable.cpp

@@ -627,7 +627,7 @@ void RenderTable::subtractCaptionRect(LayoutRect& rect) const

{

for (unsigned i = 0; i < m_captions.size(); i++) {

LayoutUnit captionLogicalHeight = m_captions[i]->logicalHeight() + m_captions[i]->marginBefore() + m_captions[i]->marginAfter();

- bool captionIsBefore = (m_captions[i]->style()->captionSide() != CAPBOTTOM) ^ style()->isFlippedBlocksWritingMode();

+ bool captionIsBefore = (m_captions[i]->style()->captionSide() != CAPBOTTOM) ^ style()->slowIsFlippedBlocksWritingMode();

if (style()->isHorizontalWritingMode()) {

rect.setHeight(rect.height() - captionLogicalHeight);

if (captionIsBefore)