Source/core/rendering/shapes/ShapeOutsideInfo.cpp - Issue 669803002: Optimize for horizontal writing mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/ShapeOutsideInfo.cpp

Issue 669803002: Optimize for horizontal writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: w compile fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/shapes/ShapeOutsideInfo.cpp

diff --git a/Source/core/rendering/shapes/ShapeOutsideInfo.cpp b/Source/core/rendering/shapes/ShapeOutsideInfo.cpp

index 135457282bc7153127edf25ac80e2f3d24a0519a..c05ac02f6185038b785706aa0bfabf4d0b548124 100644

--- a/Source/core/rendering/shapes/ShapeOutsideInfo.cpp

+++ b/Source/core/rendering/shapes/ShapeOutsideInfo.cpp

@@ -317,7 +317,7 @@ LayoutRect ShapeOutsideInfo::computedShapePhysicalBoundingBox() const

LayoutRect physicalBoundingBox = computedShape().shapeMarginLogicalBoundingBox();

physicalBoundingBox.setX(physicalBoundingBox.x() + logicalLeftOffset());

- if (m_renderer.style()->isFlippedBlocksWritingMode())

+ if (m_renderer.style()->slowIsFlippedBlocksWritingMode())

physicalBoundingBox.setY(m_renderer.logicalHeight() - physicalBoundingBox.maxY());

else

physicalBoundingBox.setY(physicalBoundingBox.y() + logicalTopOffset());

@@ -333,7 +333,7 @@ LayoutRect ShapeOutsideInfo::computedShapePhysicalBoundingBox() const

FloatPoint ShapeOutsideInfo::shapeToRendererPoint(FloatPoint point) const

{

FloatPoint result = FloatPoint(point.x() + logicalLeftOffset(), point.y() + logicalTopOffset());

- if (m_renderer.style()->isFlippedBlocksWritingMode())

+ if (m_renderer.style()->slowIsFlippedBlocksWritingMode())

result.setY(m_renderer.logicalHeight() - result.y());

if (!m_renderer.style()->isHorizontalWritingMode())

result = result.transposedPoint();