Optimize for horizontal writing mode

Source/core/rendering/RenderLayer.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 2231 matching lines @@
         RenderBox* box = renderBox();
         ASSERT(box);
         result = box->borderBoxRect();
         result.unite(box->visualOverflowRect());
     }
 
     ASSERT(renderer()->view());
     return result;
 }
 
-LayoutRect RenderLayer::flippedLogicalBoundingBox() const
+static inline LayoutRect flippedLogicalBoundingBox(LayoutRect boundingBox, RenderObject* renderer)

[pdr., 2014/10/21 22:11:26]

I don't understand the purpose of making this a static.

[eae, 2014/10/21 22:21:46]

Allows it to be inlined easier. It is a very hot function.

[pdr., 2014/10/21 22:38:15]

Could we just make this inline then?

 {
-    LayoutRect result = logicalBoundingBox();
-    if (m_renderer->isBox())
-        renderBox()->flipForWritingMode(result);
+    if (!UNLIKELY(renderer->document().hasVerticalWritingMode()))
+        return boundingBox;
+
+    LayoutRect result = boundingBox;
+    if (renderer->isBox())
+        toRenderBox(renderer)->flipForWritingMode(result);
     else
-        m_renderer->containingBlock()->flipForWritingMode(result);
+        renderer->containingBlock()->flipForWritingMode(result);
     return result;
 }
 
 LayoutRect RenderLayer::physicalBoundingBox(const RenderLayer* ancestorLayer, const LayoutPoint* offsetFromRoot) const
 {
-    LayoutRect result = flippedLogicalBoundingBox();
+    LayoutRect result = flippedLogicalBoundingBox(logicalBoundingBox(), renderer());
     if (offsetFromRoot)
         result.moveBy(*offsetFromRoot);
     else
         convertToLayerCoords(ancestorLayer, result);
     return result;
 }
 
 LayoutRect RenderLayer::fragmentsBoundingBox(const RenderLayer* ancestorLayer) const
 {
     if (!enclosingPaginationLayer())
         return physicalBoundingBox(ancestorLayer);
 
-    LayoutRect result = flippedLogicalBoundingBox();
+    LayoutRect result = flippedLogicalBoundingBox(logicalBoundingBox(), renderer());
     convertFromFlowThreadToVisualBoundingBoxInAncestor(this, ancestorLayer, result);
     return result;
 }
 
+LayoutRect RenderLayer::boundingBoxForCompositingOverlapTest() const
+{
+    return overlapBoundsIncludeChildren() ? boundingBoxForCompositing() : flippedLogicalBoundingBox(logicalBoundingBox(), renderer());
+}
+
 static void expandRectForReflectionAndStackingChildren(const RenderLayer* ancestorLayer, RenderLayer::CalculateBoundsOptions options, LayoutRect& result)
 {
     if (ancestorLayer->reflectionInfo() && !ancestorLayer->reflectionInfo()->reflectionLayer()->hasCompositedLayerMapping())
         result.unite(ancestorLayer->reflectionInfo()->reflectionLayer()->boundingBoxForCompositing(ancestorLayer));
 
     ASSERT(ancestorLayer->stackingNode()->isStackingContext() || !ancestorLayer->stackingNode()->hasPositiveZOrderList());
 
 #if ENABLE(ASSERT)
     LayerListMutationDetector mutationChecker(const_cast<RenderLayer*>(ancestorLayer)->stackingNode());
 #endif
@@ skipping 571 matching lines @@
     }
 }
 
 void showLayerTree(const blink::RenderObject* renderer)
 {
     if (!renderer)
         return;
     showLayerTree(renderer->enclosingLayer());
 }
 #endif