QUIC - Added histogram to track how often chrome sends/receives

QUIC - Added histogram to track  the number of total
blocked frames sent/received when a connection is finished.

Histogram name: Net.QuicSession.BlockedFrames.Received and
                Net.QuicSession.BlockedFrames.Sent.

R=asvitkine@chromium.org, rch@chromium.org

Committed: https://crrev.com/44fecdd71055961c94e93d521e01f81fb011966c
Cr-Commit-Position: refs/heads/master@{#300739}

[Alexei Svitkine (slow), 2014-10-21 14:51:53]

LGTM % nit

https://codereview.chromium.org/669793003/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/669793003/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:17398: +    Keeps track of number of
flow-control BLOCKED frames chrome either sends or
Nit: Chrome ... or maybe just not mention the product name at all (e.g. "BLOCKED
frames either sent or received.").

[ramant (doing other things), 2014-10-21 17:23:51]

Thanks Alexei for the suggestion.

https://codereview.chromium.org/669793003/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/669793003/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:17398: +    Keeps track of number of
flow-control BLOCKED frames chrome either sends or
On 2014/10/21 14:51:52, Alexei Svitkine wrote:
> Nit: Chrome ... or maybe just not mention the product name at all (e.g.
"BLOCKED
> frames either sent or received.").

Done.

[Ryan Hamilton, 2014-10-21 19:48:15]

https://codereview.chromium.org/669793003/diff/20001/net/quic/quic_connection...
File net/quic/quic_connection_logger.cc (right):

https://codereview.chromium.org/669793003/diff/20001/net/quic/quic_connection...
net/quic/quic_connection_logger.cc:48: blocked_frame_type, NUM_BLOCKED_FRAMES);
Instead of recording entry each time we become blocked, I wonder if it would be
more useful to record, say, the number of total blocked frames sent/received
when a connection is finished?

[ramant (doing other things), 2014-10-21 22:04:10]

Patchset #3 (id:40001) has been deleted

[ramant (doing other things), 2014-10-21 22:05:31]

asvitkine@chromium.org, rch@chromium.org: PTAL.

https://codereview.chromium.org/669793003/diff/20001/net/quic/quic_connection...
File net/quic/quic_connection_logger.cc (right):

https://codereview.chromium.org/669793003/diff/20001/net/quic/quic_connection...
net/quic/quic_connection_logger.cc:48: blocked_frame_type, NUM_BLOCKED_FRAMES);
On 2014/10/21 19:48:14, Ryan Hamilton wrote:
> Instead of recording entry each time we become blocked, I wonder if it would
be
> more useful to record, say, the number of total blocked frames sent/received
> when a connection is finished?

Done.

[Alexei Svitkine (slow), 2014-10-22 15:30:46]

LGTM with a suggestion

https://codereview.chromium.org/669793003/diff/60001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/669793003/diff/60001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:17235: +<histogram
name="Net.QuicSession.BlockedFramesReceived">
Nit: One suggestion:

Name these with Net.QuicSession.BlockedFrames.Received and
Net.QuicSession.BlockedFrames.Sent, so you get grouping on the dashboard.

Both here and in the code.

[Ryan Hamilton, 2014-10-22 15:51:26]

lgtm

https://codereview.chromium.org/669793003/diff/60001/net/quic/quic_connection...
File net/quic/quic_connection_logger.h (right):

https://codereview.chromium.org/669793003/diff/60001/net/quic/quic_connection...
net/quic/quic_connection_logger.h:160: uint32 num_blocked_frames_received_;
nit: looks like you can just make these "int" to match the other such fields.

[ramant (doing other things), 2014-10-22 16:54:46]

Thanks Alexei and Ryan. Made the changes you have suggested.

https://codereview.chromium.org/669793003/diff/60001/net/quic/quic_connection...
File net/quic/quic_connection_logger.h (right):

https://codereview.chromium.org/669793003/diff/60001/net/quic/quic_connection...
net/quic/quic_connection_logger.h:160: uint32 num_blocked_frames_received_;
On 2014/10/22 15:51:26, Ryan Hamilton wrote:
> nit: looks like you can just make these "int" to match the other such fields.

Done.

https://codereview.chromium.org/669793003/diff/60001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/669793003/diff/60001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:17235: +<histogram
name="Net.QuicSession.BlockedFramesReceived">
On 2014/10/22 15:30:45, Alexei Svitkine wrote:
> Nit: One suggestion:
> 
> Name these with Net.QuicSession.BlockedFrames.Received and
> Net.QuicSession.BlockedFrames.Sent, so you get grouping on the dashboard.
> 
> Both here and in the code.

Done.

[ramant (doing other things), 2014-10-22 16:54:50]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-10-22 16:56:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669793003/80001

[commit-bot: I haz the power, 2014-10-22 17:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 17:06:17]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramant (doing other things), 2014-10-22 18:35:15]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-10-22 18:37:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669793003/80001

[commit-bot: I haz the power, 2014-10-22 20:21:54]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2014-10-22 20:22:58]

Patchset 4 (id:??) landed as
https://crrev.com/44fecdd71055961c94e93d521e01f81fb011966c
Cr-Commit-Position: refs/heads/master@{#300739}