Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 669783003: Only enable OneClickSigninHelper for web-based signin (Closed)

Created:
6 years, 1 month ago by guohui
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Only enable OneClickSigninHelper for web-based signin BUG= Committed: https://crrev.com/639bf9ee3ad459bd0a6623edb1f816eaebf4d120 Cr-Commit-Position: refs/heads/master@{#302337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/tab_helpers.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
guohui
Hey, could you please review the CL? Thanks, Hui
6 years, 1 month ago (2014-10-30 17:41:46 UTC) #2
guohui
On 2014/10/30 17:41:46, guohui wrote: > Hey, > > could you please review the CL? ...
6 years, 1 month ago (2014-10-30 17:42:23 UTC) #4
sky
LGTM
6 years, 1 month ago (2014-10-30 21:05:36 UTC) #5
Roger Tawa OOO till Jul 10th
lgtm
6 years, 1 month ago (2014-10-31 20:41:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669783003/1
6 years, 1 month ago (2014-10-31 20:43:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 22:19:58 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 22:21:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/639bf9ee3ad459bd0a6623edb1f816eaebf4d120
Cr-Commit-Position: refs/heads/master@{#302337}

Powered by Google App Engine
This is Rietveld 408576698