Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Issue 669783002: SkLazyPtr follow ups (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkLazyPtr follow ups - moves test to LazyPtrTest.cpp - adds the ability to use a Create() method with an argument BUG=skia: Committed: https://skia.googlesource.com/skia/+/e9e0dea15b4d806f5da19ffa8135d4a9c62a860b

Patch Set 1 #

Patch Set 2 : simplify #

Patch Set 3 : names, etc #

Patch Set 4 : test custom destroy methods #

Patch Set 5 : no static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -63 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkLazyPtr.h View 1 2 5 chunks +27 lines, -13 lines 0 comments Download
D tests/LazyPtr.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
A + tests/LazyPtrTest.cpp View 1 2 3 4 1 chunk +32 lines, -1 line 0 comments Download

Messages

Total messages: 23 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669783002/1
6 years, 2 months ago (2014-10-20 21:35:52 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-20 21:35:53 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/134) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/122) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot ...
6 years, 2 months ago (2014-10-20 21:37:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669783002/40001
6 years, 2 months ago (2014-10-20 22:07:09 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-20 22:07:10 UTC) #8
mtklein
6 years, 2 months ago (2014-10-20 22:15:42 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 2 months ago (2014-10-21 04:07:09 UTC) #12
mtklein
now with a test for custom Destroy methods
6 years, 2 months ago (2014-10-21 19:08:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669783002/60001
6 years, 2 months ago (2014-10-21 19:09:27 UTC) #15
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-21 19:09:28 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/149)
6 years, 2 months ago (2014-10-21 19:11:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669783002/80001
6 years, 2 months ago (2014-10-21 19:13:29 UTC) #20
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-21 19:13:30 UTC) #21
reed1
lgtm
6 years, 2 months ago (2014-10-21 19:18:24 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 19:20:10 UTC) #23
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as e9e0dea15b4d806f5da19ffa8135d4a9c62a860b

Powered by Google App Engine
This is Rietveld 408576698