Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 669733011: Factor SVG root inline box paint code into SVGRootInlineBoxPainter (Closed)

Created:
6 years, 2 months ago by pdr.
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, rune+blink, Stephen Chennney, zoltan1
Project:
blink
Visibility:
Public.

Description

Factor SVG root inline box paint code into SVGRootInlineBoxPainter This patch moves the SVGRootInlineBox paint code into SVGRootInlineBoxPainter. This is a pure code move (no real changes). BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184133

Patch Set 1 #

Patch Set 2 : Rebase for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -30 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/core/paint/SVGRootInlineBoxPainter.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
A Source/core/paint/SVGRootInlineBoxPainter.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.cpp View 1 chunk +2 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pdr.
PTAL
6 years, 2 months ago (2014-10-21 23:14:18 UTC) #2
leviw_travelin_and_unemployed
LGTM.
6 years, 2 months ago (2014-10-21 23:19:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669733011/1
6 years, 2 months ago (2014-10-21 23:19:35 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/core.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-21 23:19:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669733011/20001
6 years, 2 months ago (2014-10-21 23:43:46 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 01:09:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184133

Powered by Google App Engine
This is Rietveld 408576698