Add a typical mobile page set for energy consumption.

Add a typical mobile page set for energy consumption.

BUG=

Committed: https://crrev.com/4e52d0b408f701b7ad1082b4d352e02b1cb4fa05
Cr-Commit-Position: refs/heads/master@{#300607}

[sullivan, 2014-10-21 16:05:53]

I'm trying to follow the instructions at
http://www.chromium.org/developers/telemetry/record_a_page_set.

tools/perf/record_wpr --browser=system typical_25_mobile_page_set

Gives the following error:
Usage: record_wpr <PageSet|Benchmark>

What did I miss?

[tonyg, 2014-10-21 16:20:54]

tonyg@chromium.org changed reviewers:
+ tonyg@chromium.org

[tonyg, 2014-10-21 16:20:54]

https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
File tools/perf/page_sets/typical_25_mobile.py (right):

https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
tools/perf/page_sets/typical_25_mobile.py:22: class
Typical25MobilePageSet(page_set_module.PageSet):
What's the cycle time like w/ 25 URLs and 40s pauses? Should we consider maybe
10-15 URLs to start? BTW, the URLs chosen all look excellent.

[sullivan, 2014-10-21 16:36:35]

+ariblue

Ari, I'm trying to record the page set in this code review following the
instructions at http://www.chromium.org/developers/telemetry/record_a_page_set

I've tried many incantations such as:

tools/perf/record_wpr --browser=system typical_25_mobile_page_set
tools/perf/record_wpr --browser=system typical_25_mobile
tools/perf/record_wpr tools/perf/page_sets/typical_25_mobile.py
tools/perf/record_wpr page_sets/typical_25_mobile

But I always just get the usage string. Any idea what I'm doing wrong?

https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
File tools/perf/page_sets/typical_25_mobile.py (right):

https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
tools/perf/page_sets/typical_25_mobile.py:22: class
Typical25MobilePageSet(page_set_module.PageSet):
On 2014/10/21 16:20:54, tonyg wrote:
> What's the cycle time like w/ 25 URLs and 40s pauses? Should we consider maybe
> 10-15 URLs to start? BTW, the URLs chosen all look excellent.

I am still trying to record the page set so I can get the cycle time :/

My plan is to record traces for a lot of pages, and prune out the ones that are
similar enough that they're not giving us new information. I'll also update the
name of the benchmark when that's done :)

[ariblue, 2014-10-21 18:56:10]

On 2014/10/21 16:36:35, sullivan wrote:
> +ariblue
> 
> Ari, I'm trying to record the page set in this code review following the
> instructions at http://www.chromium.org/developers/telemetry/record_a_page_set
> 
> I've tried many incantations such as:
> 
> tools/perf/record_wpr --browser=system typical_25_mobile_page_set
> tools/perf/record_wpr --browser=system typical_25_mobile
> tools/perf/record_wpr tools/perf/page_sets/typical_25_mobile.py
> tools/perf/record_wpr page_sets/typical_25_mobile
> 
> But I always just get the usage string. Any idea what I'm doing wrong?
> 
>
https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
> File tools/perf/page_sets/typical_25_mobile.py (right):
> 
>
https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
> tools/perf/page_sets/typical_25_mobile.py:22: class
> Typical25MobilePageSet(page_set_module.PageSet):
> On 2014/10/21 16:20:54, tonyg wrote:
> > What's the cycle time like w/ 25 URLs and 40s pauses? Should we consider
maybe
> > 10-15 URLs to start? BTW, the URLs chosen all look excellent.
> 
> I am still trying to record the page set so I can get the cycle time :/
> 
> My plan is to record traces for a lot of pages, and prune out the ones that
are
> similar enough that they're not giving us new information. I'll also update
the
> name of the benchmark when that's done :)

Hey, sorry for the issue. Try:

tools/perf/record_wpr --browser=system typical25_mobile_page_set

[sullivan, 2014-10-21 21:10:18]

On 2014/10/21 18:56:10, ariblue wrote:
> On 2014/10/21 16:36:35, sullivan wrote:
> > +ariblue
> > 
> > Ari, I'm trying to record the page set in this code review following the
> > instructions at
http://www.chromium.org/developers/telemetry/record_a_page_set
> > 
> > I've tried many incantations such as:
> > 
> > tools/perf/record_wpr --browser=system typical_25_mobile_page_set
> > tools/perf/record_wpr --browser=system typical_25_mobile
> > tools/perf/record_wpr tools/perf/page_sets/typical_25_mobile.py
> > tools/perf/record_wpr page_sets/typical_25_mobile
> > 
> > But I always just get the usage string. Any idea what I'm doing wrong?
> > 
> >
>
https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
> > File tools/perf/page_sets/typical_25_mobile.py (right):
> > 
> >
>
https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
> > tools/perf/page_sets/typical_25_mobile.py:22: class
> > Typical25MobilePageSet(page_set_module.PageSet):
> > On 2014/10/21 16:20:54, tonyg wrote:
> > > What's the cycle time like w/ 25 URLs and 40s pauses? Should we consider
> maybe
> > > 10-15 URLs to start? BTW, the URLs chosen all look excellent.
> > 
> > I am still trying to record the page set so I can get the cycle time :/
> > 
> > My plan is to record traces for a lot of pages, and prune out the ones that
> are
> > similar enough that they're not giving us new information. I'll also update
> the
> > name of the benchmark when that's done :)
> 
> Hey, sorry for the issue. Try:
> 
> tools/perf/record_wpr --browser=system typical25_mobile_page_set

Thanks, that worked!

[sullivan, 2014-10-21 21:11:14]

This is ready for review now.

https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
File tools/perf/page_sets/typical_25_mobile.py (right):

https://codereview.chromium.org/669733009/diff/1/tools/perf/page_sets/typical...
tools/perf/page_sets/typical_25_mobile.py:22: class
Typical25MobilePageSet(page_set_module.PageSet):
On 2014/10/21 16:36:35, sullivan wrote:
> On 2014/10/21 16:20:54, tonyg wrote:
> > What's the cycle time like w/ 25 URLs and 40s pauses? Should we consider
maybe
> > 10-15 URLs to start? BTW, the URLs chosen all look excellent.
> 
> I am still trying to record the page set so I can get the cycle time :/
> 
> My plan is to record traces for a lot of pages, and prune out the ones that
are
> similar enough that they're not giving us new information. I'll also update
the
> name of the benchmark when that's done :)

Cycle time was indeed too long. Cut it down to 10 pages, added some more
international pages.

[tonyg, 2014-10-21 21:27:54]

The CQ bit was checked by tonyg@chromium.org

[tonyg, 2014-10-21 21:27:54]

lgtm

[tonyg, 2014-10-21 21:28:08]

The CQ bit was unchecked by tonyg@chromium.org

[sullivan, 2014-10-21 21:30:09]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2014-10-21 21:31:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669733009/20001

[commit-bot: I haz the power, 2014-10-21 23:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 23:10:49]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[tonyg, 2014-10-21 23:13:38]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-10-21 23:17:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669733009/20001

[commit-bot: I haz the power, 2014-10-22 01:40:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-22 04:05:01]

Patchset 2 (id:??) landed as
https://crrev.com/4e52d0b408f701b7ad1082b4d352e02b1cb4fa05
Cr-Commit-Position: refs/heads/master@{#300607}