Cronet: remove base javatests from cronet instrumentation tests

Cronet: remove base javatests from cronet instrumentation tests

BUG=424685
Committed: https://crrev.com/ea649ee1e8c59e895df94e0b7e1dfeb5b2fa10eb
Cr-Commit-Position: refs/heads/master@{#300539}

[xunjieli, 2014-10-20 16:32:06]

xunjieli@chromium.org changed reviewers:
+ mef@chromium.org, mmenke@chromium.org

[xunjieli, 2014-10-20 16:32:07]

I looked at the base javatests that are currently included in cronet's
instrumentation tests. They do not seem very relevant
(https://code.google.com/p/chromium/codesearch#chromium/src/base/android/javat...).

The easiest way to fix the cronet buildbot problem might be that we only run our
cronet instrumentation tests and not the four base javatest classes. WDYT? PTAL.

[mmenke, 2014-10-21 16:31:50]

On 2014/10/20 16:32:07, xunjieli wrote:
> I looked at the base javatests that are currently included in cronet's
> instrumentation tests. They do not seem very relevant
>
(https://code.google.com/p/chromium/codesearch#chromium/src/base/android/javat...).
> 
> The easiest way to fix the cronet buildbot problem might be that we only run
our
> cronet instrumentation tests and not the four base javatest classes. WDYT?
PTAL.

I think this is reasonable, LGTM.  If we really want to run those tests, can
modify the recipes to run them.

[mef, 2014-10-21 18:41:31]

On 2014/10/21 16:31:50, mmenke wrote:
> On 2014/10/20 16:32:07, xunjieli wrote:
> > I looked at the base javatests that are currently included in cronet's
> > instrumentation tests. They do not seem very relevant
> >
>
(https://code.google.com/p/chromium/codesearch#chromium/src/base/android/javat...).
> > 
> > The easiest way to fix the cronet buildbot problem might be that we only run
> our
> > cronet instrumentation tests and not the four base javatest classes. WDYT?
> PTAL.
> 
> I think this is reasonable, LGTM.  If we really want to run those tests, can
> modify the recipes to run them.

LGTM. It would be nice to run tests if available for base/ functionality that we
are actually using,
but this may be lower priority than making bot green.

[mmenke, 2014-10-21 18:44:04]

On 2014/10/21 18:41:31, mef wrote:
> On 2014/10/21 16:31:50, mmenke wrote:
> > On 2014/10/20 16:32:07, xunjieli wrote:
> > > I looked at the base javatests that are currently included in cronet's
> > > instrumentation tests. They do not seem very relevant
> > >
> >
>
(https://code.google.com/p/chromium/codesearch#chromium/src/base/android/javat...).
> > > 
> > > The easiest way to fix the cronet buildbot problem might be that we only
run
> > our
> > > cronet instrumentation tests and not the four base javatest classes. WDYT?
> > PTAL.
> > 
> > I think this is reasonable, LGTM.  If we really want to run those tests, can
> > modify the recipes to run them.
> 
> LGTM. It would be nice to run tests if available for base/ functionality that
we
> are actually using,
> but this may be lower priority than making bot green.

If we want to run the tests, I think it would make more sense to update the
recipe to do so, rather than putting them in the same binary.

[xunjieli, 2014-10-21 18:48:46]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2014-10-21 18:49:51]

On 2014/10/21 18:41:31, mef wrote:
> On 2014/10/21 16:31:50, mmenke wrote:
> > On 2014/10/20 16:32:07, xunjieli wrote:
> > > I looked at the base javatests that are currently included in cronet's
> > > instrumentation tests. They do not seem very relevant
> > >
> >
>
(https://code.google.com/p/chromium/codesearch#chromium/src/base/android/javat...).
> > > 
> > > The easiest way to fix the cronet buildbot problem might be that we only
run
> > our
> > > cronet instrumentation tests and not the four base javatest classes. WDYT?
> > PTAL.
> > 
> > I think this is reasonable, LGTM.  If we really want to run those tests, can
> > modify the recipes to run them.
> 
> LGTM. It would be nice to run tests if available for base/ functionality that
we
> are actually using,
> but this may be lower priority than making bot green.

The four tests that this CL removed are not from functionalities we are using
(https://code.google.com/p/chromium/codesearch#chromium/src/base/android/javat...).
Per offline discussion, we will want to run net_unittests in our buildbots.

[commit-bot: I haz the power, 2014-10-21 18:49:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669713002/1

[commit-bot: I haz the power, 2014-10-21 19:58:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-21 19:59:08]

Patchset 1 (id:??) landed as
https://crrev.com/ea649ee1e8c59e895df94e0b7e1dfeb5b2fa10eb
Cr-Commit-Position: refs/heads/master@{#300539}