Plugin Power Saver: Restrict Power Saver to cross-origin.

content/renderer/pepper/pepper_plugin_instance_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 377 matching lines @@
   }
 }
 
 }  // namespace
 
 // static
 PepperPluginInstanceImpl* PepperPluginInstanceImpl::Create(
     RenderFrameImpl* render_frame,
     PluginModule* module,
     WebPluginContainer* container,
-    const GURL& plugin_url) {
+    const GURL& plugin_url,
+    const GURL& top_frame_url) {
   base::Callback<const void*(const char*)> get_plugin_interface_func =
       base::Bind(&PluginModule::GetPluginInterface, module);
   PPP_Instance_Combined* ppp_instance_combined =
       PPP_Instance_Combined::Create(get_plugin_interface_func);
   if (!ppp_instance_combined)
     return NULL;
 
   return new PepperPluginInstanceImpl(render_frame,
                                       module,
                                       ppp_instance_combined,
                                       container,
-                                      plugin_url);
+                                      plugin_url,
+                                      top_frame_url);
 }
 
 PepperPluginInstanceImpl::ExternalDocumentLoader::ExternalDocumentLoader()
     : finished_loading_(false) {}
 
 PepperPluginInstanceImpl::ExternalDocumentLoader::~ExternalDocumentLoader() {}
 
 void PepperPluginInstanceImpl::ExternalDocumentLoader::ReplayReceivedData(
     WebURLLoaderClient* document_loader) {
   for (std::list<std::string>::iterator it = data_.begin(); it != data_.end();
@@ skipping 50 matching lines @@
   blink::WebGamepads webkit_data;
   RenderThreadImpl::current()->SampleGamepads(&webkit_data);
   ConvertWebKitGamepadData(bit_cast<ppapi::WebKitGamepads>(webkit_data), data);
 }
 
 PepperPluginInstanceImpl::PepperPluginInstanceImpl(
     RenderFrameImpl* render_frame,
     PluginModule* module,
     ppapi::PPP_Instance_Combined* instance_interface,
     WebPluginContainer* container,
-    const GURL& plugin_url)
+    const GURL& plugin_url,
+    const GURL& top_frame_url)
     : RenderFrameObserver(render_frame),
       render_frame_(render_frame),
       module_(module),
       instance_interface_(instance_interface),
       pp_instance_(0),
       container_(container),
       layer_bound_to_fullscreen_(false),
       layer_is_hardware_(false),
       plugin_url_(plugin_url),
       power_saver_enabled_(false),
@@ skipping 85 matching lines @@
   }
 
   RendererPpapiHostImpl* host_impl = module_->renderer_ppapi_host();
   resource_creation_ = host_impl->CreateInProcessResourceCreationAPI(this);
 
   if (GetContentClient()->renderer() &&  // NULL in unit tests.
       GetContentClient()->renderer()->IsExternalPepperPlugin(module->name()))
     external_document_load_ = true;
 
   // TODO(tommycli): Insert heuristics to determine whether plugin content
   // is peripheral here.

[groby-ooo-7-16, 2014/10/23 00:17:21]

I think now would be a good time to add a heuristic function to set
is_peripheral_content :)

We'll add more heuristics over time, and I'd rather have this factored out.

[raymes, 2014/10/23 00:21:28]

Yes, please pull all this out into a function :)

[tommycli, 2014/10/23 00:46:12]

Done.

[tommycli, 2014/10/23 00:46:12]

Done.

   bool is_peripheral_content = true;
   power_saver_enabled_ = is_peripheral_content &&
       module->name() == kFlashPluginName &&
       CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnablePluginPowerSaver);
 
-  if (power_saver_enabled_) {
+  if (power_saver_enabled_ &&
+      plugin_url.GetOrigin() != top_frame_url.GetOrigin()) {
     throttler_.reset(new PepperPluginInstanceThrottler(
         base::Bind(&PepperPluginInstanceImpl::SetPluginThrottled,
                    weak_factory_.GetWeakPtr(), true /* throttled */)));
   }
 }
 
 PepperPluginInstanceImpl::~PepperPluginInstanceImpl() {
   DCHECK(!fullscreen_container_);
 
   // Notify all the plugin objects of deletion. This will prevent blink from
@@ skipping 2697 matching lines @@
 void PepperPluginInstanceImpl::SetPluginThrottled(bool throttled) {
   // Do not throttle if we've already disabled power saver.
   if (!power_saver_enabled_ && throttled)
     return;
 
   plugin_throttled_ = throttled;
   SendDidChangeView();
 }
 
 }  // namespace content