Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 669673006: Add SExpression test and share tests between dart2dart and analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer2dart/lib/src/semantic_visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index 7acf50452f33de7eb9d6f68d41c8a190c30c1677..bed7ed591cedf5b909bd4d96903c15465eac08ad 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -69,6 +69,12 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
}
@override
+ ir.Node visitMethodInvocation(MethodInvocation node) {
+ // Overridden to avoid eager visits of the receiver and arguments.
+ return handleMethodInvocation(node);
+ }
+
+ @override
ir.Primitive visitDynamicInvocation(MethodInvocation node,
AccessSemantics semantics) {
// TODO(johnniwinther): Handle implicit `this`.
@@ -137,6 +143,12 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
}
@override
+ ir.Node visitPropertyAccess(PropertyAccess node) {
+ // Overridden to avoid eager visits of the receiver.
+ return handlePropertyAccess(node);
+ }
+
+ @override
ir.Node visitLocalVariableAccess(AstNode node, AccessSemantics semantics) {
return handleLocalAccess(node, semantics);
}
« no previous file with comments | « no previous file | pkg/analyzer2dart/lib/src/semantic_visitor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698