Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 669673004: Check in executable for iOS test launcher (Closed)

Created:
6 years, 2 months ago by Paweł Hajdan Jr.
Modified:
6 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check in executable for iOS test launcher This doesn't do anything yet, mostly adds supporting infrastructure. R=lliabraa@chromium.org, mark@chromium.org, sdefresne@chromium.org, lliabraa, mark, sdefresne TBR=darin BUG=426870 Committed: https://chromium.googlesource.com/chromium/src/+/ec3246c03b35b330266ef3c26b651ab2f5876d19

Patch Set 1 #

Patch Set 2 : trybots #

Patch Set 3 : trybots #

Patch Set 4 : trybots #

Patch Set 5 : android #

Patch Set 6 : aosp #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -8 lines) Patch
M base/base.gyp View 1 2 3 4 5 6 12 chunks +34 lines, -1 line 0 comments Download
A + base/test/launcher/test_launcher_ios.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M build/android/android_exports.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M build/android/setup.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M testing/gmock.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/jsr-305/jsr-305.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/libxml.gyp View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Paweł Hajdan Jr.
Sylvain, could you review this ios-related CL?
6 years, 2 months ago (2014-10-22 09:27:03 UTC) #2
lliabraa
lgtm
6 years, 2 months ago (2014-10-22 13:21:53 UTC) #4
Paweł Hajdan Jr.
Darin, could you do OWNERS review of base and third_party?
6 years, 2 months ago (2014-10-22 13:30:35 UTC) #7
sdefresne
lgtm
6 years, 2 months ago (2014-10-22 15:29:09 UTC) #8
Paweł Hajdan Jr.
+mark for base/ OWNERS review I'm planning to TBR darin for third_party since it's not ...
6 years, 2 months ago (2014-10-24 13:11:23 UTC) #11
Mark Mentovai
LGTM in base. I don’t know that “BUG=TBD” in the commit message is useful, though. ...
6 years, 2 months ago (2014-10-24 13:15:11 UTC) #12
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/ec3246c03b35b330266ef3c26b651ab2f5876d19 Cr-Commit-Position: refs/heads/master@{#301119}
6 years, 2 months ago (2014-10-24 16:22:05 UTC) #13
Paweł Hajdan Jr.
Committed patchset #7 (id:110001) manually as ec3246c03b35b330266ef3c26b651ab2f5876d19 (presubmit successful).
6 years, 2 months ago (2014-10-24 16:22:08 UTC) #14
Yaron
On 2014/10/24 16:22:08, Paweł Hajdan Jr. wrote: > Committed patchset #7 (id:110001) manually as > ...
6 years, 2 months ago (2014-10-24 17:49:42 UTC) #15
jennyz
6 years, 2 months ago (2014-10-24 18:26:32 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:110001) has been created in
https://codereview.chromium.org/678743002/ by jennyz@chromium.org.

The reason for reverting is: This caused gclient runhooks failed with error:
gyp: Dependency
'/home/chrome-bot/chrome_root/src/third_party/zlib/zlib.gyp:zlib#host' not found
while trying to load target
/home/chrome-bot/chrome_root/src/third_party/libxml/libxml.gyp:libxml#host

See the build log:
http://build.chromium.org/p/chromiumos.chromium/builders/AMD64%20%28chromium%....

Powered by Google App Engine
This is Rietveld 408576698