Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 669673003: Use the "enableCSSViewport" method to enable CSS viewport feature (Closed)

Created:
6 years, 2 months ago by Mikhail
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Noel Gordon
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Use the "enableCSSViewport" method to enable CSS viewport feature Use the properly-named "WebRuntimeFeatures::enableCSSViewport" method to enable the CSS viewport feature instead of wrongly-named "setCSSViewportEnabled". BUG=424459 Committed: https://crrev.com/34cb061236f5c334606379297c2dfdfded0a490e Cr-Commit-Position: refs/heads/master@{#300264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/child/runtime_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mikhail
PTAL
6 years, 2 months ago (2014-10-20 12:37:08 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-20 13:56:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669673003/1
6 years, 2 months ago (2014-10-20 14:13:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 14:27:31 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 14:28:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34cb061236f5c334606379297c2dfdfded0a490e
Cr-Commit-Position: refs/heads/master@{#300264}

Powered by Google App Engine
This is Rietveld 408576698