Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 669643004: webtry: Improve error handling/message when creating sqlite tables. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
humper, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

webtry: Improve error handling/message when creating sqlite tables. In case they fail, lets fail with an ERROR message rather than an INFO, and lets make the error message a little bit better. BUG=None TEST=None R=jcgregorio@google.com Committed: https://skia.googlesource.com/skia/+/7a2df0c672d05301362b5ad13e01bfc62871200a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M experimental/webtry/webtry.go View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
6 years, 2 months ago (2014-10-21 01:52:34 UTC) #1
humper
On 2014/10/21 01:52:34, tfarina wrote: lgtm
6 years, 2 months ago (2014-10-21 02:13:10 UTC) #2
jcgregorio
lgtm
6 years, 2 months ago (2014-10-21 11:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669643004/1
6 years, 2 months ago (2014-10-22 18:49:20 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:57:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 7a2df0c672d05301362b5ad13e01bfc62871200a

Powered by Google App Engine
This is Rietveld 408576698