Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 669643003: Custom pseudo elements do not require sub-tree recalcs. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 1 month ago
Reviewers:
chrishtr, esprehn, dglazkov
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Custom pseudo elements do not require sub-tree recalcs. Custom pseudo elements are already invalidation set features and handled in invalidationSetModeForSelector and extractInvalidationSetFeature. TEST=fast/css/invalidation/targeted-class-custom-pseudo.html R=chrishtr@chromium.org,esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184438

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/css/RuleFeature.cpp View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
rune
6 years, 2 months ago (2014-10-20 21:53:57 UTC) #1
rune
PTAL
6 years, 2 months ago (2014-10-24 08:51:09 UTC) #2
dglazkov
lgtm
6 years, 2 months ago (2014-10-24 15:01:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669643003/1
6 years, 2 months ago (2014-10-24 15:02:58 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/css/RuleFeature.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-24 15:03:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669643003/20001
6 years, 2 months ago (2014-10-24 23:30:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33573)
6 years, 2 months ago (2014-10-25 02:00:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669643003/20001
6 years, 2 months ago (2014-10-25 08:50:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33593)
6 years, 1 month ago (2014-10-25 10:31:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669643003/20001
6 years, 1 month ago (2014-10-27 08:53:28 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 10:35:26 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184438

Powered by Google App Engine
This is Rietveld 408576698