Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 66963005: Mojo: Implement local passing of MessagePipes. (Closed)

Created:
7 years, 1 month ago by viettrungluu
Modified:
7 years, 1 month ago
Reviewers:
DaveMoore
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Implement local passing of MessagePipes. I.e., allow handles to MessagePipes to be transferred across MessagePipes whose ends are both local (i.e., in-process). There's one basic test of this functionality in this change, but much more is needed. Also, in theory, a handle to a remote (proxied) MessagePipe can be transferred across a local MessagePipe, but this is not tested. R=davemoore@chromium.org, davemoore Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234863

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -56 lines) Patch
M mojo/system/core_impl.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M mojo/system/core_impl_unittest.cc View 2 chunks +115 lines, -0 lines 0 comments Download
M mojo/system/core_test_base.cc View 2 chunks +6 lines, -1 line 0 comments Download
M mojo/system/dispatcher.h View 1 3 chunks +23 lines, -7 lines 0 comments Download
M mojo/system/dispatcher.cc View 1 3 chunks +18 lines, -7 lines 0 comments Download
M mojo/system/dispatcher_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/local_message_pipe_endpoint.cc View 5 chunks +27 lines, -19 lines 0 comments Download
M mojo/system/message_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 4 chunks +16 lines, -7 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.h View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 5 chunks +18 lines, -3 lines 0 comments Download
M mojo/system/message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/simple_dispatcher_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
7 years, 1 month ago (2013-11-13 00:12:03 UTC) #1
DaveMoore
lgtm https://codereview.chromium.org/66963005/diff/1/mojo/system/dispatcher.cc File mojo/system/dispatcher.cc (right): https://codereview.chromium.org/66963005/diff/1/mojo/system/dispatcher.cc#newcode39 mojo/system/dispatcher.cc:39: uint32_t* num_dispatchers, Nit: Why do you need an ...
7 years, 1 month ago (2013-11-13 02:54:02 UTC) #2
viettrungluu
On 2013/11/13 02:54:02, DaveMoore wrote: > lgtm > > https://codereview.chromium.org/66963005/diff/1/mojo/system/dispatcher.cc > File mojo/system/dispatcher.cc (right): > ...
7 years, 1 month ago (2013-11-13 17:31:57 UTC) #3
viettrungluu
7 years, 1 month ago (2013-11-13 18:53:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r234863 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698