Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 669623006: Add a "device disabled" OOBE screen (Closed)

Created:
6 years, 2 months ago by bartfab (slow)
Modified:
6 years, 2 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a "device disabled" OOBE screen This screen will be shown when the owner/administrator remotely disables a device. The CL only adds the screen. A follow-up CL will hook it up with the OOBE flow. The UI and strings are still under review and may change slightly before this feature launches. BUG=425574 TEST=Manual Committed: https://crrev.com/2edfb70f1ecf64d7fd487047364f784eea23a8ea Cr-Commit-Position: refs/heads/master@{#300731}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Addressed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/screens/device_disabled_screen.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/screens/device_disabled_screen.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/screens/device_disabled_screen_actor.h View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/oobe_display.h View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 5 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_common.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_resources.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_screens.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screens.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_device_disabled.css View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_device_disabled.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_device_disabled.js View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc View 1 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 6 chunks +16 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
bartfab (slow)
Hi Nikita, Could you take a look please?
6 years, 2 months ago (2014-10-22 09:52:07 UTC) #2
Nikita (slow)
Please add link to screenshots (Drive folder for instance).
6 years, 2 months ago (2014-10-22 10:28:25 UTC) #3
Nikita (slow)
lgtm https://codereview.chromium.org/669623006/diff/1/chrome/browser/resources/chromeos/login/screen_device_disabled.html File chrome/browser/resources/chromeos/login/screen_device_disabled.html (right): https://codereview.chromium.org/669623006/diff/1/chrome/browser/resources/chromeos/login/screen_device_disabled.html#newcode9 chrome/browser/resources/chromeos/login/screen_device_disabled.html:9: i18n-content="deviceDisabledExplanation"> nit: 4 spaces indent https://codereview.chromium.org/669623006/diff/1/chrome/browser/resources/chromeos/login/screen_device_disabled.js File chrome/browser/resources/chromeos/login/screen_device_disabled.js ...
6 years, 2 months ago (2014-10-22 10:33:53 UTC) #4
bartfab (slow)
I posted a screen shot on the bug report: http://crbug.com/425574#c2 https://codereview.chromium.org/669623006/diff/1/chrome/browser/resources/chromeos/login/screen_device_disabled.html File chrome/browser/resources/chromeos/login/screen_device_disabled.html (right): https://codereview.chromium.org/669623006/diff/1/chrome/browser/resources/chromeos/login/screen_device_disabled.html#newcode9 ...
6 years, 2 months ago (2014-10-22 11:32:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669623006/20001
6 years, 2 months ago (2014-10-22 11:32:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/28181) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/21769)
6 years, 2 months ago (2014-10-22 11:38:58 UTC) #9
Nikita (slow)
lgtm https://codereview.chromium.org/669623006/diff/1/chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc (right): https://codereview.chromium.org/669623006/diff/1/chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc#newcode40 chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc:40: } On 2014/10/22 11:32:16, bartfab wrote: > On ...
6 years, 2 months ago (2014-10-22 11:59:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669623006/20001
6 years, 2 months ago (2014-10-22 13:11:49 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 19:28:55 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 19:29:28 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2edfb70f1ecf64d7fd487047364f784eea23a8ea
Cr-Commit-Position: refs/heads/master@{#300731}

Powered by Google App Engine
This is Rietveld 408576698