Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: media/base/android/media_codec_bridge.h

Issue 669623004: Switch to Lollipop APIs for MediaCodec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove getInputBufferCount() call Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_codec_bridge.h
diff --git a/media/base/android/media_codec_bridge.h b/media/base/android/media_codec_bridge.h
index da2348f497556b9b86cc715dc038552721c6de7d..84a8fc0f7c9347e2f2ea392b6ffee29ec0a29461 100644
--- a/media/base/android/media_codec_bridge.h
+++ b/media/base/android/media_codec_bridge.h
@@ -102,9 +102,6 @@ class MEDIA_EXPORT MediaCodecBridge {
// returns a format change by returning INFO_OUTPUT_FORMAT_CHANGED
void GetOutputFormat(int* width, int* height);
- // Returns the number of input buffers used by the codec.
- int GetInputBuffersCount();
-
// Submits a byte array to the given input buffer. Call this after getting an
// available buffer from DequeueInputBuffer(). If |data| is NULL, assume the
// input buffer has already been populated (but still obey |size|).
@@ -164,16 +161,13 @@ class MEDIA_EXPORT MediaCodecBridge {
void ReleaseOutputBuffer(int index, bool render);
// Returns the number of output buffers used by the codec.
+ // TODO(qinmin): this call is deprecated in Lollicap.
mcasas 2014/10/23 07:19:28 s/Lollicap/Lollipop/
qinmin 2014/10/23 22:42:52 Done.
int GetOutputBuffersCount();
// Returns the capacity of each output buffer used by the codec.
+ // TODO(qinmin): this call is deprecated in Lollicap.
mcasas 2014/10/23 07:19:28 Idem.
qinmin 2014/10/23 22:42:52 Done.
size_t GetOutputBuffersCapacity();
- // Gets output buffers from media codec and keeps them inside the java class.
- // To access them, use DequeueOutputBuffer(). Returns whether output buffers
- // were successfully obtained.
- bool GetOutputBuffers() WARN_UNUSED_RESULT;
-
// Returns an input buffer's base pointer and capacity.
void GetInputBuffer(int input_buffer_index, uint8** data, size_t* capacity);

Powered by Google App Engine
This is Rietveld 408576698