Switch to Lollipop APIs for MediaCodec

Switch to Lollipop APIs for MediaCodec

Some of the MediaCodec APIs are deprecated in L, replace them with new APIs.
For WebRTC, it relies on some calls to get the output buffer count and capacities. this needs to be fixed.

BUG=412185
Committed: https://crrev.com/21b94f4b7dc6f6c7855981c61183f4f4312108f4
Cr-Commit-Position: refs/heads/master@{#305486}

[qinmin, 2014-10-21 00:38:31]

qinmin@chromium.org changed reviewers:
+ mcasas@chromium.org, xhwang@chromium.org

[qinmin, 2014-10-21 00:38:32]

@xhwang, please revoew media/base/android/

@mcasas, please review content/common/gpu/media/. GetOutputBufferCount() and
GetOutputBufferCapacity() will be deprecated for L, so please modify the rtc
code to remove the reliance on those calls.

[xhwang, 2014-10-22 16:19:17]

media/base/android/ lgtm

[mcasas, 2014-10-23 07:19:28]

LGTM.

(I think you swapped the owner reviewership :) )

https://codereview.chromium.org/669623004/diff/20001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
(right):

https://codereview.chromium.org/669623004/diff/20001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:332: }
Shouldn't we catch MediaCodec.CodecException as well?

http://developer.android.com/reference/android/media/MediaCodec.html#getInput...

https://codereview.chromium.org/669623004/diff/20001/media/base/android/media...
File media/base/android/media_codec_bridge.h (right):

https://codereview.chromium.org/669623004/diff/20001/media/base/android/media...
media/base/android/media_codec_bridge.h:164: // TODO(qinmin): this call is
deprecated in Lollicap.
s/Lollicap/Lollipop/

https://codereview.chromium.org/669623004/diff/20001/media/base/android/media...
media/base/android/media_codec_bridge.h:168: // TODO(qinmin): this call is
deprecated in Lollicap.
Idem.

[qinmin, 2014-10-23 22:42:53]

https://codereview.chromium.org/669623004/diff/20001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
(right):

https://codereview.chromium.org/669623004/diff/20001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:332: }
MediaCodec.CodecException is a subclass of the IllegalStateException.
So if we catch the latter, we shouldn't need to catch the latter. And since the
latter is API 20, so we have to always include it for backward compatibilities.

On 2014/10/23 07:19:28, mcasas wrote:
> Shouldn't we catch MediaCodec.CodecException as well?
> 
>
http://developer.android.com/reference/android/media/MediaCodec.html#getInput...

https://codereview.chromium.org/669623004/diff/20001/media/base/android/media...
File media/base/android/media_codec_bridge.h (right):

https://codereview.chromium.org/669623004/diff/20001/media/base/android/media...
media/base/android/media_codec_bridge.h:164: // TODO(qinmin): this call is
deprecated in Lollicap.
On 2014/10/23 07:19:28, mcasas wrote:
> s/Lollicap/Lollipop/

Done.

https://codereview.chromium.org/669623004/diff/20001/media/base/android/media...
media/base/android/media_codec_bridge.h:168: // TODO(qinmin): this call is
deprecated in Lollicap.
On 2014/10/23 07:19:28, mcasas wrote:
> Idem.

Done.

[qinmin, 2014-10-23 22:42:57]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-10-23 23:01:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669623004/40001

[commit-bot: I haz the power, 2014-10-23 23:42:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 23:42:22]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[mcasas, 2014-11-24 03:44:04]

On 2014/10/23 23:42:22, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_aosp on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

I think you can land this now.

[qinmin, 2014-11-24 18:54:01]

+dalecurtis for content/common/gpu/media/ OWNER

mcasas was removed from the OWNER file during the review of the CL

[DaleCurtis, 2014-11-24 19:21:50]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2014-11-24 19:21:51]

rs lgtm

[qinmin, 2014-11-24 19:31:12]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-11-24 19:31:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/669623004/60001

[commit-bot: I haz the power, 2014-11-24 20:25:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-24 20:26:53]

Patchset 4 (id:??) landed as
https://crrev.com/21b94f4b7dc6f6c7855981c61183f4f4312108f4
Cr-Commit-Position: refs/heads/master@{#305486}

[Senthil, 2015-04-29 00:24:43]

On 2014/10/23 22:42:53, qinmin wrote:
>
https://codereview.chromium.org/669623004/diff/20001/media/base/android/java/...
> File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
> (right):
> 
>
https://codereview.chromium.org/669623004/diff/20001/media/base/android/java/...
> media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:332: }
> MediaCodec.CodecException is a subclass of the IllegalStateException.
> So if we catch the latter, we shouldn't need to catch the latter. And since
the
> latter is API 20, so we have to always include it for backward
compatibilities.
> 
> On 2014/10/23 07:19:28, mcasas wrote:
> > Shouldn't we catch MediaCodec.CodecException as well?
> > 
> >
>
http://developer.android.com/reference/android/media/MediaCodec.html#getInput...
> 
>
https://codereview.chromium.org/669623004/diff/20001/media/base/android/media...
> File media/base/android/media_codec_bridge.h (right):
> 
>
https://codereview.chromium.org/669623004/diff/20001/media/base/android/media...
> media/base/android/media_codec_bridge.h:164: // TODO(qinmin): this call is
> deprecated in Lollicap.
> On 2014/10/23 07:19:28, mcasas wrote:
> > s/Lollicap/Lollipop/
> 
> Done.
> 
>
https://codereview.chromium.org/669623004/diff/20001/media/base/android/media...
> media/base/android/media_codec_bridge.h:168: // TODO(qinmin): this call is
> deprecated in Lollicap.
> On 2014/10/23 07:19:28, mcasas wrote:
> > Idem.
> 
> Done.

Hi QinMin,
I am trying to enable hardware VP8 encoding for WebRTC for our platform. When i
enabled the encoder, i saw a crash in ChildProcessHostImpl::AllocateSharedMemory
with an invalid buffer_size of -1. This is because the GetOutputBuffersCapacity
returns -1. 

I saw your commit to update the code for changes in Android-L and the mention
that outputbuffers still need to be fixed. Can you please let me know if it is
fixed or when it will be fixed ?

thanks
Senthil