Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 669613005: Ensure that the browser’s copy of page id is in sync with the renderer’s. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ensure that the browser’s copy of page id is in sync with the renderer’s. This might-maybe-hope-not crash, and so has debugging statements. BUG=407376 TEST=no crashing, we hope TBR=rsesek@chromium.org Committed: https://crrev.com/31111d18aadc37181a249afa74a62ac46544e12e Cr-Commit-Position: refs/heads/master@{#300311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M chrome/common/crash_keys.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Avi (use Gerrit)
While I investigate the session history, we should check to see if the failures were ...
6 years, 2 months ago (2014-10-20 17:59:10 UTC) #2
Charlie Reis
Yeah, there's a chance duplicate routing IDs could have caused these failures. LGTM to find ...
6 years, 2 months ago (2014-10-20 18:31:26 UTC) #3
Avi (use Gerrit)
On 2014/10/20 18:31:26, Charlie Reis wrote: > Yeah, there's a chance duplicate routing IDs could ...
6 years, 2 months ago (2014-10-20 18:33:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669613005/1
6 years, 2 months ago (2014-10-20 18:35:43 UTC) #6
Robert Sesek
On 2014/10/20 18:33:41, Avi wrote: > On 2014/10/20 18:31:26, Charlie Reis wrote: > > Yeah, ...
6 years, 2 months ago (2014-10-20 18:53:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 19:20:46 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31111d18aadc37181a249afa74a62ac46544e12e Cr-Commit-Position: refs/heads/master@{#300311}
6 years, 2 months ago (2014-10-20 19:21:24 UTC) #9
Avi (use Gerrit)
6 years, 2 months ago (2014-10-21 15:37:07 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/669943002/ by avi@chromium.org.

The reason for reverting is: Crashing. Still..

Powered by Google App Engine
This is Rietveld 408576698