src/vm-state-inl.h - Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/vm-state-inl.h

Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/isolates

Patch Set: Addressing code review feedback + rebase Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/vm-state-inl.h

diff --git a/src/vm-state-inl.h b/src/vm-state-inl.h

index 6cd6663305bcbc1ee45777bf19947397f81c549e..1f363de626d0dd55f3cb8e3260b85c6dacff58dd 100644

--- a/src/vm-state-inl.h

+++ b/src/vm-state-inl.h

@@ -63,8 +63,8 @@ VMState::VMState(Isolate* isolate, StateTag tag)

: isolate_(isolate), previous_tag_(isolate->current_vm_state()) {

#ifdef ENABLE_LOGGING_AND_PROFILING

if (FLAG_log_state_changes) {

- LOG(UncheckedStringEvent("Entering", StateToString(tag)));

- LOG(UncheckedStringEvent("From", StateToString(previous_tag_)));

+ LOG(isolate, UncheckedStringEvent("Entering", StateToString(tag)));

+ LOG(isolate, UncheckedStringEvent("From", StateToString(previous_tag_)));

}

#endif

@@ -88,9 +88,11 @@ VMState::VMState(Isolate* isolate, StateTag tag)

VMState::~VMState() {

#ifdef ENABLE_LOGGING_AND_PROFILING

if (FLAG_log_state_changes) {

- LOG(UncheckedStringEvent("Leaving",

- StateToString(isolate_->current_vm_state())));

- LOG(UncheckedStringEvent("To", StateToString(previous_tag_)));

+ LOG(isolate_,

+ UncheckedStringEvent("Leaving",

+ StateToString(isolate_->current_vm_state())));

+ LOG(isolate_,

+ UncheckedStringEvent("To", StateToString(previous_tag_)));

}

#endif // ENABLE_LOGGING_AND_PROFILING

« no previous file with comments | « src/top.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »