src/jsregexp.cc - Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/jsregexp.cc

Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/isolates

Patch Set: Addressing code review feedback + rebase Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/jsregexp.cc

diff --git a/src/jsregexp.cc b/src/jsregexp.cc

index af03e75afcb77fd8cef48bc65ff5cae185306aa8..2db8ddff9fde0a716ac28fe31e000fea386a0162 100644

--- a/src/jsregexp.cc

+++ b/src/jsregexp.cc

@@ -117,7 +117,7 @@ Handle<Object> RegExpImpl::Compile(Handle<JSRegExp> re,

CompilationCache* compilation_cache = isolate->compilation_cache();

Handle<FixedArray> cached = compilation_cache->LookupRegExp(pattern, flags);

bool in_cache = !cached.is_null();

- LOG(RegExpCompileEvent(re, in_cache));

+ LOG(isolate, RegExpCompileEvent(re, in_cache));

Handle<Object> result;

if (in_cache) {

« no previous file with comments | « src/isolate.cc ('k') | src/log.h » ('j') | no next file with comments »