Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669603007: Adds the page for hotword-only to the opt-in flow. (Closed)

Created:
6 years, 2 months ago by kcarattini
Modified:
6 years, 2 months ago
Reviewers:
rpetterson, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds the page for hotword-only to the opt-in flow. Updates the UI button text to reflect the latest mocks. BUG=390086 Committed: https://crrev.com/c5626d7dfe2e8fa73099ee89f9c0782c3c40d6c8 Cr-Commit-Position: refs/heads/master@{#300618}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -40 lines) Patch
M chrome/browser/resources/hotword_audio_verification/flow.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/hotword_audio_verification/main.js View 1 2 chunks +29 lines, -12 lines 0 comments Download
M chrome/browser/resources/hotword_audio_verification/steps/finished_step.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/hotword_audio_verification/steps/hotword_only_step.html View 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/resources/hotword_audio_verification/steps/speech_training_step.html View 1 chunk +26 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kcarattini
dbeam@: Please review for OWNERS approval in chrome/browser/resources
6 years, 2 months ago (2014-10-21 06:22:43 UTC) #4
Dan Beam
rs lgtm https://codereview.chromium.org/669603007/diff/1/chrome/browser/resources/hotword_audio_verification/main.js File chrome/browser/resources/hotword_audio_verification/main.js (right): https://codereview.chromium.org/669603007/diff/1/chrome/browser/resources/hotword_audio_verification/main.js#newcode28 chrome/browser/resources/hotword_audio_verification/main.js:28: e.stopPropagation(); why are you stopping propagation? probably ...
6 years, 2 months ago (2014-10-21 18:17:38 UTC) #5
rpetterson
Overall LGTM
6 years, 2 months ago (2014-10-21 18:31:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669603007/20001
6 years, 2 months ago (2014-10-21 23:56:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 02:00:21 UTC) #9
kcarattini
https://codereview.chromium.org/669603007/diff/1/chrome/browser/resources/hotword_audio_verification/main.js File chrome/browser/resources/hotword_audio_verification/main.js (right): https://codereview.chromium.org/669603007/diff/1/chrome/browser/resources/hotword_audio_verification/main.js#newcode28 chrome/browser/resources/hotword_audio_verification/main.js:28: e.stopPropagation(); On 2014/10/21 18:17:38, Dan Beam wrote: > why ...
6 years, 2 months ago (2014-10-22 03:47:27 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:05:23 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c5626d7dfe2e8fa73099ee89f9c0782c3c40d6c8
Cr-Commit-Position: refs/heads/master@{#300618}

Powered by Google App Engine
This is Rietveld 408576698