Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 669603003: Convert fast/multicol/flipped-blocks-border-after to reftest. (Closed)

Created:
6 years, 2 months ago by andersr
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/flipped-blocks-border-after to reftest. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184248

Patch Set 1 #

Patch Set 2 : Make test more understandable by humans. #

Patch Set 3 : Keep 50px border, it was probably that large for a reason. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -40 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/multicol/flipped-blocks-border-after.html View 1 2 1 chunk +68 lines, -18 lines 0 comments Download
A LayoutTests/fast/multicol/flipped-blocks-border-after-expected.html View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/flipped-blocks-border-after-expected.png View Binary file 0 comments Download
D LayoutTests/fast/multicol/flipped-blocks-border-after-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/flipped-blocks-border-after-expected.png View Binary file 0 comments Download

Messages

Total messages: 7 (1 generated)
andersr
6 years, 2 months ago (2014-10-20 13:43:48 UTC) #1
mstensho (USE GERRIT)
While turning it into a reftest certainly is a great improvement, I still prefer tests ...
6 years, 2 months ago (2014-10-20 20:53:18 UTC) #2
andersr
On 2014/10/20 20:53:18, mstensho wrote: > While turning it into a reftest certainly is a ...
6 years, 2 months ago (2014-10-21 11:02:39 UTC) #3
mstensho (USE GERRIT)
On 2014/10/21 11:02:39, andersr wrote: > On 2014/10/20 20:53:18, mstensho wrote: > > While turning ...
6 years, 2 months ago (2014-10-21 11:12:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669603003/30001
6 years, 2 months ago (2014-10-23 07:21:11 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 09:09:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as 184248

Powered by Google App Engine
This is Rietveld 408576698