Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 6696023: Remove minidump analysis aides from URLRequestThrottlerManager. New (Closed)

Created:
9 years, 9 months ago by Jói
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove minidump analysis aides from URLRequestThrottlerManager. New minidumps are not giving us any extra information. We've confirmed that this is a memory overwrite coming from somewhere else, and to catch it we will most likely need to reproduce it under a memory debugging tool. I've left in the guard against null values as it seems to avoid the crash and since we aren't getting more information from additional minidumps for this particular crash I think it's best to lessen the impact on our users. BUG=71721 TEST=net_unittests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+515 lines, -330 lines) Patch
M chrome/common/net/url_fetcher_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A net/base/backoff_entry.h View 1 chunk +96 lines, -0 lines 0 comments Download
A net/base/backoff_entry.cc View 1 chunk +112 lines, -0 lines 0 comments Download
A net/base/backoff_entry_unittest.cc View 1 chunk +185 lines, -0 lines 0 comments Download
M net/net.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M net/url_request/url_request_throttler_entry.h View 6 chunks +11 lines, -37 lines 0 comments Download
M net/url_request/url_request_throttler_entry.cc View 6 chunks +40 lines, -114 lines 0 comments Download
M net/url_request/url_request_throttler_entry_interface.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/url_request/url_request_throttler_header_adapter.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_throttler_manager.h View 5 chunks +3 lines, -20 lines 0 comments Download
M net/url_request/url_request_throttler_manager.cc View 6 chunks +9 lines, -70 lines 0 comments Download
M net/url_request/url_request_throttler_unittest.cc View 6 chunks +47 lines, -79 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698